Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mapbox/css-color-parser-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tangrams/css-color-parser-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 3 files changed
  • 3 contributors

Commits on Jul 26, 2015

  1. csscolorparser: optimization

    @hjanetzek
    hjanetzek committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    37fabd8 View commit details
    Browse the repository at this point in the history

  2. avoid two string copies in the hex rgba case

    @hjanetzek
    hjanetzek committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    b6f8608 View commit details
    Browse the repository at this point in the history

  3. actually parse hex argb not just rgb

    @hjanetzek
    hjanetzek committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    f0f6c4b View commit details
    Browse the repository at this point in the history

  4. csscolorparser: 

    - set isValid state flag on success
- no heap allocation for NamedColor parsing
- check the actual length of the parsed string for hex format
    @hjanetzek
    hjanetzek committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    50e85e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2015

  1. no more heap allocations

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    caaa955 View commit details
    Browse the repository at this point in the history

  2. split up parse()

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    1ee853c View commit details
    Browse the repository at this point in the history

  3. following the test-suite

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    02895f0 View commit details
    Browse the repository at this point in the history

  4. add test for more strict parsing

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    b95f7d5 View commit details
    Browse the repository at this point in the history

  5. add Color.getInt()

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    77a5430 View commit details
    Browse the repository at this point in the history

  6. use constepxr for NamedColors[]

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    0648ce0 View commit details
    Browse the repository at this point in the history

  7. switch on first character

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    80a458a View commit details
    Browse the repository at this point in the history

  8. minor tweak, skip matched #

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    c2052a6 View commit details
    Browse the repository at this point in the history

  9. change back to return color 

    --alloc in prefix match
    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    44fc7f3 View commit details
    Browse the repository at this point in the history

  10. cleanups

    @hjanetzek
    hjanetzek committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    80b74a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2015

  1. const for getInt

    @hjanetzek
    hjanetzek committed Aug 19, 2015
    Configuration menu
    Copy the full SHA
    1771826 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2016

  1. + rebeccapurple 

    http://meyerweb.com/eric/thoughts/2014/06/19/rebeccapurple/
http://www.color-hex.com/color/663399
untested, but should be OK
    @tomByrer
    tomByrer committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    19fa629 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from tomByrer/patch-1 

    + rebeccapurple
    @hjanetzek
    hjanetzek committed Feb 21, 2016
    Configuration menu
    Copy the full SHA
    fa90421 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2016

  1. Getting csscolorparser works with vs 2015. (deanm#2)

    @lygstate @tallytalwar
    lygstate authored and tallytalwar committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    5be17df View commit details
    Browse the repository at this point in the history
Loading