Skip to content

Commit 80b6de1

Browse files
committed
Accordion: Pass original event in beforeActivate event.
1 parent 01b92ff commit 80b6de1

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

tests/unit/accordion/accordion_events.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
module( "accordion: events", accordionSetupTeardown() );
44

55
test( "beforeActivate", function() {
6-
expect( 42 );
6+
expect( 47 );
77
var ac = $( "#list1" ).accordion({
88
active: false,
99
collapsible: true
@@ -12,6 +12,7 @@ test( "beforeActivate", function() {
1212
var content = ac.find( ".ui-accordion-content" );
1313

1414
ac.one( "accordionbeforeactivate", function( event, ui ) {
15+
ok( !( "originalEvent" in event ) );
1516
equals( ui.oldHeader.size(), 0 );
1617
equals( ui.oldContent.size(), 0 );
1718
equals( ui.newHeader.size(), 1 );
@@ -24,6 +25,7 @@ test( "beforeActivate", function() {
2425
state( ac, 1, 0, 0 );
2526

2627
ac.one( "accordionbeforeactivate", function( event, ui ) {
28+
equals( event.originalEvent.type, "click" );
2729
equals( ui.oldHeader.size(), 1 );
2830
strictEqual( ui.oldHeader[ 0 ], headers[ 0 ] );
2931
equals( ui.oldContent.size(), 1 );
@@ -38,6 +40,7 @@ test( "beforeActivate", function() {
3840
state( ac, 0, 1, 0 );
3941

4042
ac.one( "accordionbeforeactivate", function( event, ui ) {
43+
ok( !( "originalEvent" in event ) );
4144
equals( ui.oldHeader.size(), 1 );
4245
strictEqual( ui.oldHeader[ 0 ], headers[ 1 ] );
4346
equals( ui.oldContent.size(), 1 );
@@ -50,6 +53,7 @@ test( "beforeActivate", function() {
5053
state( ac, 0, 0, 0 );
5154

5255
ac.one( "accordionbeforeactivate", function( event, ui ) {
56+
ok( !( "originalEvent" in event ) );
5357
equals( ui.oldHeader.size(), 0 );
5458
equals( ui.oldContent.size(), 0 );
5559
equals( ui.newHeader.size(), 1 );
@@ -63,6 +67,7 @@ test( "beforeActivate", function() {
6367
state( ac, 0, 0, 0 );
6468

6569
ac.one( "accordionbeforeactivate", function( event, ui ) {
70+
equals( event.originalEvent.type, "click" );
6671
equals( ui.oldHeader.size(), 0 );
6772
equals( ui.oldContent.size(), 0 );
6873
equals( ui.newHeader.size(), 1 );

ui/jquery.ui.accordion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ $.widget( "ui.accordion", {
319319
// click on active header, but not collapsible
320320
( clickedIsActive && !options.collapsible ) ||
321321
// allow canceling activation
322-
( this._trigger( "beforeActivate", null, eventData ) === false ) ) {
322+
( this._trigger( "beforeActivate", event, eventData ) === false ) ) {
323323
return;
324324
}
325325

0 commit comments

Comments
 (0)