Rewrote tests

Author: christophervoigt

packages/stylelint-config-airbnb/index.js

@@ -3,27 +3,19 @@ module.exports = {
     'stylelint-scss',
   ],
   rules: {
+    indentation: 2,
+    'max-nesting-depth': 2,
+    'selector-no-id': true,
+    'selector-list-comma-newline-after': 'always',
+    'rule-non-nested-empty-line-before': ['always', { ignore: ['after-comment'] }],
+    'no-invalid-double-slash-comments': true,
+    'comment-empty-line-before': ['always', { ignore: ['stylelint-commands'] }],
     'at-rule-empty-line-before': 'never',
     'block-opening-brace-space-before': 'always',
-    'comment-empty-line-before': ['always', {
-      ignore: ['stylelint-commands'],
-    }],
     'declaration-colon-space-after': 'always',
     'declaration-colon-space-before': 'never',
-    indentation: 2,
-    'max-nesting-depth': 3,
-    'no-invalid-double-slash-comments': true,
-    'rule-non-nested-empty-line-before': ['always', {
-      ignore: ['after-comment'],
-    }],
-    'selector-list-comma-newline-after': 'always',
-    'selector-no-id': true,
-
     'scss/dollar-variable-pattern': '^[_a-z][\\w-]*$',
     'scss/at-extend-no-missing-placeholder': true,
-
-    'declaration-property-value-blacklist': {
-      '/^border/': ['none'],
-    },
+    'declaration-property-value-blacklist': { '/^border/': ['none'] },
   },
 };

packages/stylelint-config-airbnb/test/test-base-invalid.scss

@@ -11,8 +11,7 @@ $BadVariable: none;
   border: none;
 }
 
-// .bad-comment { color: pink }
-
+// bad comment
 .foo {
   border: none;
 }
@@ -21,10 +20,8 @@ $BadVariable: none;
 .page-container {
   .content {
     .profile {
-      .image {
-        .toodeep {
+      .toodeep {
 
-        }
       }
     }
   }

packages/stylelint-config-airbnb/test/test-base-valid.scss

@@ -12,6 +12,7 @@ $_my-private-variable: 2px;
   border: 2px;
 }
 
+/* good comment */
 .foo {
   border: 0;
 }

packages/stylelint-config-airbnb/test/test-base.js

@@ -31,112 +31,112 @@ test('warnings with invalid css', t => {
     const { errored, results } = data;
     const { warnings } = results[0];
     t.truthy(errored, 'errored');
-    t.is(warnings.length, 21, 'flags one warning');
+    t.is(warnings.length, 21, 'flags 21 warnings');
 
     t.is(warnings[0].text,
-      'Unexpected empty line before at-rule (at-rule-empty-line-before)',
-      'correct warning text'
+      'Expected indentation of 2 spaces (indentation)',
+      'flags wrong indentation'
     );
 
     t.is(warnings[1].text,
-      'Expected single space before "{" (block-opening-brace-space-before)',
-      'correct warning text'
+      'Expected indentation of 2 spaces (indentation)',
+      'flags wrong indentation'
     );
 
     t.is(warnings[2].text,
-      'Expected empty line before comment (comment-empty-line-before)',
-      'correct warning text'
+      'Expected nesting depth to be no more than 2 (max-nesting-depth)',
+      'flags nesting depth when more than 2'
     );
 
     t.is(warnings[3].text,
-      'Expected single space after ":" (declaration-colon-space-after)',
-      'correct warning text'
+      'Unexpected id selector (selector-no-id)',
+      'flags id selector'
     );
 
     t.is(warnings[4].text,
-      'Expected single space after ":" (declaration-colon-space-after)',
-      'correct warning text'
+      'Expected newline after "," (selector-list-comma-newline-after)',
+      'flags missing newline after ","'
     );
 
     t.is(warnings[5].text,
-      'Unexpected whitespace before ":" (declaration-colon-space-before)',
-      'correct warning text'
+      'Expected newline after "," (selector-list-comma-newline-after)',
+      'flags missing newline after ","'
     );
 
     t.is(warnings[6].text,
-      'Expected indentation of 2 spaces (indentation)',
-      'correct warning text'
+      'Expected empty line before non-nested rule (rule-non-nested-empty-line-before)',
+      'flags missing empty line before non-nested rule'
     );
 
     t.is(warnings[7].text,
-      'Expected indentation of 2 spaces (indentation)',
-      'correct warning text'
+      'Expected empty line before non-nested rule (rule-non-nested-empty-line-before)',
+      'flags missing empty line before non-nested rule'
     );
 
     t.is(warnings[8].text,
-      'Expected nesting depth to be no more than 3 (max-nesting-depth)',
-      'correct warning text'
+      'Expected empty line before non-nested rule (rule-non-nested-empty-line-before)',
+      'flags missing empty line before non-nested rule'
     );
 
     t.is(warnings[9].text,
       'Unexpected double-slash CSS comment (no-invalid-double-slash-comments)',
-      'correct warning text'
+      'flags double-slash comments'
     );
 
     t.is(warnings[10].text,
-      'Expected empty line before non-nested rule (rule-non-nested-empty-line-before)',
-      'correct warning text'
+      'Expected empty line before comment (comment-empty-line-before)',
+      'flags missing empty line before comment'
     );
 
     t.is(warnings[11].text,
-      'Expected empty line before non-nested rule (rule-non-nested-empty-line-before)',
-      'correct warning text'
+      'Unexpected empty line before at-rule (at-rule-empty-line-before)',
+      'flags missing empty line before non-nested rule'
     );
 
     t.is(warnings[12].text,
-      'Expected empty line before non-nested rule (rule-non-nested-empty-line-before)',
-      'correct warning text'
+      'Expected single space before "{" (block-opening-brace-space-before)',
+      'flags missing single space before "{"'
     );
 
     t.is(warnings[13].text,
-      'Expected newline after "," (selector-list-comma-newline-after)',
-      'correct warning text'
+      'Expected single space after ":" (declaration-colon-space-after)',
+      'flags missing single space after ":"'
     );
 
     t.is(warnings[14].text,
-      'Expected newline after "," (selector-list-comma-newline-after)',
-      'correct warning text'
+      'Expected single space after ":" (declaration-colon-space-after)',
+      'flags missing single space after ":"'
     );
 
     t.is(warnings[15].text,
-      'Unexpected id selector (selector-no-id)',
-      'correct warning text'
+      'Unexpected whitespace before ":" (declaration-colon-space-before)',
+      'flags whitepace before ":"'
     );
 
     t.is(warnings[16].text,
       'Expected $ variable name to match specified pattern (scss/dollar-variable-pattern)',
-      'correct warning text'
+      'flags variables of wrong convention'
     );
 
     t.is(warnings[17].text,
       'Expected a placeholder selector (e.g. %placeholder) to be used in ' +
       '@extend (scss/at-extend-no-missing-placeholder)',
-      'correct warning text'
+      'flags wrong @extend statements'
     );
 
     t.is(warnings[18].text,
       'Unexpected value "none" for property "border" (declaration-property-value-blacklist)',
-      'correct warning text'
+      'flags "border: none" statements'
     );
 
     t.is(warnings[19].text,
       'Unexpected value "none" for property "border" (declaration-property-value-blacklist)',
-      'correct warning text'
+      'flags "border: none" statements'
     );
 
     t.is(warnings[20].text,
       'Unexpected value "none" for property "border" (declaration-property-value-blacklist)',
-      'correct warning text'
+      'flags "border: none" statements'
     );
   });