Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PencilCode/jquery-turtle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: timaschew/jquery-turtle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 55 files changed
  • 2 contributors

Commits on Jan 19, 2016

  1. Implement browserify and prepare sourcecode for splitting into severa… 

    …l files.
    @MarkusBordihn
    MarkusBordihn committed Jan 19, 2016
    Configuration menu
    Copy the full SHA
    c6d392b View commit details
    Browse the repository at this point in the history

  2. Generate compiled and minimized code and move them to the dist/ dir.

    @MarkusBordihn
    MarkusBordihn committed Jan 19, 2016
    Configuration menu
    Copy the full SHA
    9430367 View commit details
    Browse the repository at this point in the history

  3. cleanup browserify stuff 

    - browserify-shim is only needed if you want to include a file which wants to pollute the global scope
- we assume jquery is loaded by the end user, so there is no need to use the shim
- we also don't need to require('jquery'), because we need it exclude it then when bundling
- so instead just don't require jquery and assume it's there in the global scope
- expose the library into $.turtle
- use just grunt test to start phantom, no need to use grunt as bundler anymore

- not sure what turtle needs to export, but $.turtle() results into a string: "eval(see.init())"
- test are not working, there is something really strange with the scope, need input by @davidbau
    @timaschew
    timaschew committed Jan 19, 2016
    Configuration menu
    Copy the full SHA
    9358eb6 View commit details
    Browse the repository at this point in the history

  4. add bundled files

    @timaschew
    timaschew committed Jan 19, 2016
    Configuration menu
    Copy the full SHA
    dc46c46 View commit details
    Browse the repository at this point in the history

  5. fix typo

    @timaschew
    timaschew committed Jan 19, 2016
    Configuration menu
    Copy the full SHA
    ca04b1f View commit details
    Browse the repository at this point in the history
Loading