8000 Tabs: Style updates · timmywil/jquery-ui@063885f · GitHub
Skip to content

Commit 063885f

Browse files
arschmitzarschmitz
committed
Tabs: Style updates
Ref #14246 Ref jquerygh-1588
1 parent b7278a3 commit 063885f

7 files changed

Lines changed: 66 additions & 66 deletions

File tree

‎demos/tabs/manipulation.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var tabs = $( "#tabs" ).tabs();
2424

25-
// modal dialog init: custom buttons and a "close" callback resetting the form inside
25+
// Modal dialog init: custom buttons and a "close" callback resetting the form inside
2626
var dialog = $( "#dialog" ).dialog({
2727
autoOpen: false,
2828
modal: true,
@@ -40,14 +40,14 @@
4040
}
4141
});
4242

43-
// addTab form: calls addTab function on submit and closes the dialog
43+
// AddTab form: calls addTab function on submit and closes the dialog
4444
var form = dialog.find( "form" ).on( "submit", function( event ) {
4545
addTab();
4646
dialog.dialog( "close" );
4747
event.preventDefault();
4848
});
4949

50-
// actual addTab function: adds new tab using the input from the form above
50+
// Actual addTab function: adds new tab using the input from the form above
5151
function addTab() {
5252
var label = tabTitle.val() || "Tab " + tabCounter,
5353
id = "tabs-" + tabCounter,
@@ -60,14 +60,14 @@
6060
tabCounter++;
6161
}
6262

63-
// addTab button: just opens the dialog
63+
// AddTab button: just opens the dialog
6464
$( "#add_tab" )
6565
.button()
6666
.on( "click", function() {
6767
dialog.dialog( "open" );
6868
});
6969

70-
// close icon: removing the tab on click
70+
// Close icon: removing the tab on click
7171
tabs.on( "click", "span.ui-icon-close", function() {
7272
var panelId = $( this ).closest( "li" ).remove().attr( "aria-controls" );
7373
$( "#" + panelId ).remove();

‎tests/unit/tabs/common.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ common.testWidget( "tabs", {
1919
hide: null,
2020
show: null,
2121

22-
// callbacks
22+
// Callbacks
2323
activate: null,
2424
beforeActivate: null,
2525
beforeLoad: null,

‎tests/unit/tabs/core.js‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ asyncTest( "keyboard support - LEFT, RIGHT, UP, DOWN, HOME, END, SPACE, ENTER",
191191
equal( tabs.filter( ".ui-state-focus" ).length, 0, "no tabs focused on init" );
192192
tabs.eq( 0 ).simulate( "focus" );
193193

194-
// down, right, down (wrap), up (wrap)
194+
// Down, right, down (wrap), up (wrap)
195195
function step1() {
196196
assert.hasClasses( tabs.eq( 0 ), "ui-state-focus", "first tab has focus" );
197197
equal( tabs.eq( 0 ).attr( "aria-selected" ), "true", "first tab has aria-selected=true" );
@@ -242,7 +242,7 @@ asyncTest( "keyboard support - LEFT, RIGHT, UP, DOWN, HOME, END, SPACE, ENTER",
242242
setTimeout( step2, 25 );
243243
}
244244

245-
// left, home, space
245+
// Left, home, space
246246
function step2() {
247247
equal( tabs.eq( 2 ).attr( "aria-selected" ), "true", "third tab has aria-selected=true" );
248248
equal( tabs.eq( 0 ).attr( "aria- 1822 selected" ), "false", "first tab has aria-selected=false" );
@@ -280,7 +280,7 @@ asyncTest( "keyboard support - LEFT, RIGHT, UP, DOWN, HOME, END, SPACE, ENTER",
280280
setTimeout( step3 );
281281
}
282282

283-
// end, enter
283+
// End, enter
284284
function step3() {
285285
equal( tabs.eq( 0 ).attr( "aria-selected" ), "true", "first tab has aria-selected=true" );
286286
equal( tabs.eq( 2 ).attr( "aria-selected" ), "false", "third tab has aria-selected=false" );
@@ -307,7 +307,7 @@ asyncTest( "keyboard support - LEFT, RIGHT, UP, DOWN, HOME, END, SPACE, ENTER",
307307
setTimeout( step4 );
308308
}
309309

310-
// enter (collapse)
310+
// Enter (collapse)
311311
function step4() {
312312
equal( tabs.eq( 2 ).attr( "aria-selected" ), "true", "third tab has aria-selected=true" );
313313
ok( panels.eq( 2 ).is( ":visible" ), "third panel is visible" );
@@ -347,7 +347,7 @@ $.each({
347347
equal( tabs.filter( ".ui-state-focus" ).length, 0, "no tabs focused on init" );
348348
tabs.eq( 0 ).simulate( "focus" );
349349

350-
// down
350+
// Down
351351
function step1() {
352352
var eventProperties = { keyCode: keyCode.DOWN };
353353
eventProperties[ modifier + "Key" ] = true;
@@ -371,7 +371,7 @@ $.each({
371371
setTimeout( step2, 25 );
372372
}
373373

374-
// right
374+
// Right
375375
function step2() {
376376
var eventProperties = { keyCode: keyCode.RIGHT };
377377
eventProperties[ modifier + "Key" ] = true;
@@ -398,7 +398,7 @@ $.each({
398398
setTimeout( step3, 25 );
399399
}
400400

401-
// down (wrap)
401+
// Down (wrap)
402402
function step3() {
403403
var eventProperties = { keyCode: keyCode.DOWN };
404404
eventProperties[ modifier + "Key" ] = true;
@@ -421,7 +421,7 @@ $.each({
421421
setTimeout( step4, 25 );
422422
}
423423

424-
// up (wrap)
424+
// Up (wrap)
425425
function step4() {
426426
var eventProperties = { keyCode: keyCode.UP };
427427
eventProperties[ modifier + "Key" ] = true;
@@ -445,7 +445,7 @@ $.each({
445445
setTimeout( step5, 25 );
446446
}
447447

448-
// left
448+
// Left
449449
function step5() {
450450
var eventProperties = { keyCode: keyCode.LEFT };
451451
eventProperties[ modifier + "Key" ] = true;
@@ -472,7 +472,7 @@ $.each({
472472
setTimeout( step6, 25 );
473473
}
474474

475-
// home
475+
// Home
476476
function step6() {
477477
var eventProperties = { keyCode: keyCode.HOME };
478478
eventProperties[ modifier + "Key" ] = true;
@@ -499,7 +499,7 @@ $.each({
499499
setTimeout( step7, 25 );
500500
}
501501

502-
// end
502+
// End
503503
function step7() {
504504
var eventProperties = { keyCode: keyCode.END };
505505
eventProperties[ modifier + "Key" ] = true;
@@ -523,7 +523,7 @@ $.each({
523523
setTimeout( step8, 25 );
524524
}
525525

526-
// space
526+
// Space
527527
function step8() {
528528
equal( tabs.eq( 0 ).attr( "aria-selected" ), "true", "first tab has aria-selected=true" );
529529
ok( panels.eq( 0 ).is( ":visible" ), "first panel is visible" );

‎tests/unit/tabs/events.js‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ test( "beforeActivate", function() {
5858
anchors = tabs.find( ".ui-tabs-anchor" ),
5959
panels = element.find( ".ui-tabs-panel" );
6060

61-
// from collapsed
61+
// From collapsed
6262
element.one( "tabsbeforeactivate", function( event, ui ) {
6363
ok( !( "originalEvent" in event ), "originalEvent" );
6464
equal( ui.oldTab.length, 0, "oldTab length" );
@@ -72,7 +72,7 @@ test( "beforeActivate", function() {
7272
element.tabs( "option", "active", 0 );
7373
state( element, 1, 0, 0 );
7474

75-
// switching tabs
75+
// Switching tabs
7676
element.one( "tabsbeforeactivate", function( event, ui ) {
7777
equal( event.originalEvent.type, "click", "originalEvent" );
7878
equal( ui.oldTab.length, 1, "oldTab length" );
@@ -88,7 +88,7 @@ test( "beforeActivate", function() {
8888
anchors.eq( 1 ).trigger( "click" );
8989
state( element, 0, 1, 0 );
9090

91-
// collapsing
91+
// Collapsing
9292
element.one( "tabsbeforeactivate", function( event, ui ) {
9393
ok( !( "originalEvent" in event ), "originalEvent" );
9494
equal( ui.oldTab.length, 1, "oldTab length" );
@@ -102,7 +102,7 @@ test( "beforeActivate", function() {
102102
element.tabs( "option", "active", false );
103103
state( element, 0, 0, 0 );
104104

105-
// prevent activation
105+
// Prevent activation
106106
element.one( "tabsbeforeactivate", function( event, ui ) {
107107
ok( !( "originalEvent" in event ), "originalEvent" );
108108
equal( ui.oldTab.length, 0, "oldTab length" );
@@ -129,7 +129,7 @@ test( "activate", function() {
129129
anchors = element.find( ".ui-tabs-anchor" ),
130130
panels = element.find( ".ui-tabs-panel" );
131131

132-
// from collapsed
132+
// From collapsed
133133
element.one( "tabsactivate", function( event, ui ) {
134134
ok( !( "originalEvent" in event ), "originalEvent" );
135135
equal( ui.oldTab.length, 0, "oldTab length" );
@@ -143,7 +143,7 @@ test( "activate", function() {
143143
element.tabs( "option", "active", 0 );
144144
state( element, 1, 0, 0 );
145145

146-
// switching tabs
146+
// Switching tabs
147147
element.one( "tabsactivate", function( event, ui ) {
148148
equal( event.originalEvent.type, "click", "originalEvent" );
149149
equal( ui.oldTab.length, 1, "oldTab length" );
@@ -159,7 +159,7 @@ test( "activate", function() {
159159
anchors.eq( 1 ).trigger( "click" );
160160
state( element, 0, 1, 0 );
161161

162-
// collapsing
162+
// Collapsing
163163
element.one( "tabsactivate", function( event, ui ) {
164164
ok( !( "originalEvent" in event ), "originalEvent" );
165165
equal( ui.oldTab.length, 1, "oldTab length" );
@@ -173,7 +173,7 @@ test( "activate", function() {
173173
element.tabs( "option", "active", false );
174174
state( element, 0, 0, 0 );
175175

176-
// prevent activation
176+
// Prevent activation
177177
element.one( "tabsbeforeactivate", function( event ) {
178178
ok( true, "tabsbeforeactivate" );
179179
event.preventDefault();
@@ -190,7 +190,7 @@ test( "beforeLoad", function() {
190190
var tab, panelId, panel,
191191
element = $( "#tabs2" );
192192

193-
// init
193+
// Init
194194
element.one( "tabsbeforeload", function( event, ui ) {
195195
tab = element.find( ".ui-tabs-nav li" ).eq( 2 );
196196
panelId = tab.attr( "aria-controls" );
@@ -234,7 +234,7 @@ test( "beforeLoad", function() {
234234
state( element, 0, 0, 1, 0, 0 );
235235
equal( panel.html(), "", "panel html after" );
236236

237-
// click, change panel content
237+
// Click, change panel content
238238
element.one( "tabsbeforeload", function( event, ui ) {
239239
tab = element.find( ".ui-tabs-nav li" ).eq( 3 );
240240
panelId = tab.attr( "aria-controls" );
@@ -263,7 +263,7 @@ asyncTest( "load", function() {
263263
var tab, panelId, panel,
264264
element = $( "#tabs2" );
265265

266-
// init
266+
// Init
267267
element.one( "tabsload", function( event, ui ) {
268268
tab = element.find( ".ui-tabs-nav li" ).eq( 2 );
269269
panelId = tab.attr( "aria-controls" );

‎tests/unit/tabs/methods.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -110,27 +110,27 @@ test( "refresh", function() {
110110
state( element, 1, 0, 0 );
111111
disabled( element, false );
112112

113-
// disable tab via markup
113+
// Disable tab via markup
114114
element.find( ".ui-tabs-nav li" ).eq( 1 ).addClass( "ui-state-disabled" );
115115
element.tabs( "refresh" );
116116
state( element, 1, 0, 0 );
117117
disabled( element, [ 1 ] );
118118

119-
// add remote tab
119+
// Add remote tab
120120
element.find( ".ui-tabs-nav" ).append( "<li id='newTab'><a href='data/test.html'>new</a></li>" );
121121
element.tabs( "refresh" );
122122
state( element, 1, 0, 0, 0 );
123123
disabled( element, [ 1 ] );
124124
equal( element.find( "#" + $( "#newTab" ).attr( "aria-controls" ) ).length, 1,
125125
"panel added for remote tab" );
126126

127-
// remove all tabs
127+
// Remove all tabs
128128
element.find( ".ui-tabs-nav li, .ui-tabs-panel" ).remove();
129129
element.tabs( "refresh" );
130130
state( element );
131131
equal( element.tabs( "option", "active" ), false, "no active tab" );
132132

133-
// add tabs
133+
// Add tabs
134134
element.find( ".ui-tabs-nav" )
135135
.append( "<li class='ui-state-disabled'><a href='#newTab2'>new 2</a></li>" )
136136
.append( "<li><a href='#newTab3'>new 3</a></li>" )
@@ -145,26 +145,26 @@ test( "refresh", function() {
145145
state( element, 0, 0, 0, 0 );
146146
disabled( element, [ 0 ] );
147147

148-
// activate third tab
148+
// Activate third tab
149149
element.tabs( "option", "active", 2 );
150150
state( element, 0, 0, 1, 0 );
151151
disabled( element, [ 0 ] );
152152

153-
// remove fourth tab, third tab should stay active
153+
// Remove fourth tab, third tab should stay active
154154
element.find( ".ui-tabs-nav li" ).eq( 3 ).remove();
155155
element.find( ".ui-tabs-panel" ).eq( 3 ).remove();
156156
element.tabs( "refresh" );
157157
state( element, 0, 0, 1 );
158158
disabled( element, [ 0 ] );
159159

160-
// remove third (active) tab, second tab should become active
160+
// Remove third (active) tab, second tab should become active
161161
element.find( ".ui-tabs-nav li" ).eq( 2 ).remove();
162162
element.find( ".ui-tabs-panel" ).eq( 2 ).remove();
163163
element.tabs( "refresh" );
164164
state( element, 0, 1 );
165165
disabled( element, [ 0 ] );
166166

167-
// remove first tab, previously active tab (now first) should stay active
167+
// Remove first tab, previously active tab (now first) should stay active
168168
element.find( ".ui-tabs-nav li" ).eq( 0 ).remove();
169169
element.find( ".ui-tabs-panel" ).eq( 0 ).remove();
170170
element.tabs( "refresh" );
@@ -182,7 +182,7 @@ test( "refresh - looping", function() {
182182
state( element, 0, 1, 0 );
183183
disabled( element, [ 0 ] );
184184

185-
// remove active, jump to previous
185+
// Remove active, jump to previous
186186
// previous is disabled, just back one more
187187
// reached first tab, move to end
188188
// activate last tab
@@ -197,7 +197,7 @@ asyncTest( "load", function() {
197197

198198
var element = $( "#tabs2" ).tabs();
199199

200-
// load content of inactive tab
200+
// Load content of inactive tab
201201
// useful for preloading content with custom caching
202202
element.one( "tabsbeforeload", function( event, ui ) {
203203
var tab = element.find( ".ui-tabs-nav li" ).eq( 3 ),

0 commit comments

Comments
 (0)