refactor: toString method in favor of polymorphism (postcss#208)

vankop · evilebottnawi · commit 56156f70701e · 2019-08-29T15:06:28.000+03:00
diff --git a/src/selectors/className.js b/src/selectors/className.js
@@ -27,11 +27,7 @@ export default class ClassName extends Node {
         return this._value;
     }
 
-    toString () {
-        return [
-            this.rawSpaceBefore,
-            String('.' + this.stringifyProperty("value")),
-            this.rawSpaceAfter,
-        ].join('');
+    valueToString () {
+        return '.' + super.valueToString();
     }
 }
diff --git a/src/selectors/id.js b/src/selectors/id.js
@@ -7,11 +7,7 @@ export default class ID extends Node {
         this.type = IDType;
     }
 
-    toString () {
-        return [
-            this.rawSpaceBefore,
-            String('#' + this.stringifyProperty("value")),
-            this.rawSpaceAfter,
-        ].join('');
+    valueToString () {
+        return '#' + super.valueToString();
     }
 }
diff --git a/src/selectors/namespace.js b/src/selectors/namespace.js
@@ -52,11 +52,7 @@ export default class Namespace extends Node {
         }
     }
 
-    toString () {
-        return [
-            this.rawSpaceBefore,
-            this.qualifiedName(this.stringifyProperty("value")),
-            this.rawSpaceAfter,
-        ].join('');
+    valueToString () {
+        return this.qualifiedName(super.valueToString());
     }
 };
diff --git a/src/selectors/node.js b/src/selectors/node.js
@@ -124,7 +124,7 @@ export default class Node {
     }
 
     /**
-     * 
+     *
      * @param {number} line The number (starting with 1)
      * @param {number} column The column number (starting with 1)
      */
@@ -177,10 +177,14 @@ export default class Node {
         this.raws.spaces.after = raw;
     }
 
+    valueToString () {
+        return String(this.stringifyProperty("value"));
+    }
+
     toString () {
         return [
             this.rawSpaceBefore,
-            String(this.stringifyProperty("value")),
+            this.valueToString(),
             this.rawSpaceAfter,
         ].join('');
     }

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,7 @@ export default class ClassName extends Node {`
`27`	`27`	`return this._value;`
`28`	`28`	`}`
`29`	`29`
`30`		`- toString () {`
`31`		`- return [`
`32`		`- this.rawSpaceBefore,`
`33`		`- String('.' + this.stringifyProperty("value")),`
`34`		`- this.rawSpaceAfter,`
`35`		`- ].join('');`
	`30`	`+ valueToString () {`
	`31`	`+ return '.' + super.valueToString();`
`36`	`32`	`}`
`37`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,11 +7,7 @@ export default class ID extends Node {`
`7`	`7`	`this.type = IDType;`
`8`	`8`	`}`
`9`	`9`
`10`		`- toString () {`
`11`		`- return [`
`12`		`- this.rawSpaceBefore,`
`13`		`- String('#' + this.stringifyProperty("value")),`
`14`		`- this.rawSpaceAfter,`
`15`		`- ].join('');`
	`10`	`+ valueToString () {`
	`11`	`+ return '#' + super.valueToString();`
`16`	`12`	`}`
`17`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,11 +52,7 @@ export default class Namespace extends Node {`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`		`- toString () {`
`56`		`- return [`
`57`		`- this.rawSpaceBefore,`
`58`		`- this.qualifiedName(this.stringifyProperty("value")),`
`59`		`- this.rawSpaceAfter,`
`60`		`- ].join('');`
	`55`	`+ valueToString () {`
	`56`	`+ return this.qualifiedName(super.valueToString());`
`61`	`57`	`}`
`62`	`58`	`};`