IE11 Unspecified Error

RobinHerbots · RobinHerbots · commit 049985471426 · 2017-01-18T12:00:55.000+01:00
Hi @trentrichardson, When calling setSelectionRange on an input element which is currently not visible, you get an unspecified error in IE11. I added a little check for this. Fixes trentrichardson#848
diff --git a/src/jquery-ui-timepicker-addon.js b/src/jquery-ui-timepicker-addon.js
@@ -888,7 +888,7 @@
 				else {
 					this.$timeObj.val($.datepicker.formatTime(pickerTimeFormat, this, o) + pickerTimeSuffix);
 				}
-				if (this.$timeObj[0].setSelectionRange) {
+				if (this.$timeObj[0].setSelectionRange && this.$timeObj.is(":visible")) {
 					var sPos = this.$timeObj[0].selectionStart;
 					var ePos = this.$timeObj[0].selectionEnd;
 					this.$timeObj[0].setSelectionRange(sPos, ePos);

Original file line number	Diff line number	Diff line change
`@@ -888,7 +888,7 @@`
`888`	`888`	`else {`
`889`	`889`	`this.$timeObj.val($.datepicker.formatTime(pickerTimeFormat, this, o) + pickerTimeSuffix);`
`890`	`890`	`}`
`891`		`- if (this.$timeObj[0].setSelectionRange) {`
	`891`	`+ if (this.$timeObj[0].setSelectionRange && this.$timeObj.is(":visible")) {`
`892`	`892`	`var sPos = this.$timeObj[0].selectionStart;`
`893`	`893`	`var ePos = this.$timeObj[0].selectionEnd;`
`894`	`894`	`this.$timeObj[0].setSelectionRange(sPos, ePos);`