[popup] Use new ._on() binding method to attach handlers such that they are removed upon _destroy()

Author: Gabriel Schulhof

js/widgets/popup.js

@@ -158,17 +158,7 @@ define( [ "jquery",
 				_isOpen: false,
 				_tolerance: null,
 				_resizeData: null,
-				_orientationchangeInProgress: false,
-				_globalHandlers: [
-					{
-						src: $( window ),
-						handler: {
-							orientationchange: $.proxy( this, "_handleWindowOrientationchange" ),
-							resize: $.proxy( this, "_handleWindowResize" ),
-							keyup: $.proxy( this, "_handleWindowKeyUp" )
-						}
-					}
-				]
+				_orientationchangeInProgress: false
 			});
 
 			$.each( this.options, function( key, value ) {
@@ -179,9 +169,10 @@ define( [ "jquery",
 			});
 
 			ui.screen.bind( "vclick", $.proxy( this, "_eatEventAndClose" ) );
-
-			$.each( this._globalHandlers, function( idx, value ) {
-				value.src.bind( value.handler );
+			this._on( window, {
+				orientationChange: "_handleWindowOrientationChange",
+				resize: "_handleWindowResize",
+				keyup: "_handleWindowKeyUp"
 			});
 		},
 
@@ -579,13 +570,6 @@ define( [ "jquery",
 			this._ui.screen.remove();
 			this._ui.container.remove();
 			this._ui.placeholder.remove();
-
-			// Unbind handlers that were bound to elements outside this.element (the window, in this case)
-			$.each( this._globalHandlers, function( idx, oneSrc ) {
-				$.each( oneSrc.handler, function( eventType, handler ) {
-					oneSrc.src.unbind( eventType, handler );
-				});
-			});
 		},
 
 		open: function( options ) {