Skip to content

Commit 5912d36

Browse files
committed
Readme: Added more details about landing pull requests.
1 parent 00086a8 commit 5912d36

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ To discuss development with team members and the community, visit the [Developin
1111

1212
For contributors
1313
---
14+
1415
If you want to help and provide a patch for a bugfix or new feature, please take
1516
a few minutes and look at [our Getting Involved guide](http://wiki.jqueryui.com/w/page/35263114/Getting-Involved).
1617
In particular check out the [Coding standards](http://wiki.jqueryui.com/w/page/12137737/Coding-standards)
@@ -53,9 +54,15 @@ Run grunt.
5354

5455
For committers
5556
---
57+
5658
When looking at pull requests, first check for [proper commit messages](http://wiki.jqueryui.com/w/page/12137724/Bug-Fixing-Guide).
5759

5860
Do not merge pull requests directly through GitHub's interface.
61+
Most pull requests are a single commit; cherry-picking will avoid creating a merge commit.
62+
It's also common for contributors to make minor fixes in an additional one or two commits.
63+
These should be squashed before landing in master.
64+
65+
**Make sure the author has a valid name and email address associated with the commit.**
5966

6067
Fetch the remote first:
6168

0 commit comments

Comments
 (0)