Skip to content

Commit 6a00d41

Browse files
committed
Tabs: Removed spinner option. Fixes #7151 - Tabs: Remove spinner option.
1 parent a9053d9 commit 6a00d41

File tree

3 files changed

+0
-45
lines changed

3 files changed

+0
-45
lines changed

tests/unit/tabs/tabs_common_deprecated.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ TestHelpers.commonWidgetTests( "tabs", {
99
idPrefix: "ui-tabs-",
1010
panelTemplate: "<div></div>",
1111
show: null,
12-
spinner: "<em>Loading&#8230;</em>",
1312
tabTemplate: "<li><a href='#{href}'><span>#{label}</span></a></li>",
1413

1514
// callbacks

tests/unit/tabs/tabs_deprecated.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -66,24 +66,6 @@ test( "tabTemplate + panelTemplate", function() {
6666
ok( element.find( "#new" ).hasClass( "customPanel" ), "panel custom class" );
6767
});
6868

69-
asyncTest( "spinner", function() {
70-
expect( 2 );
71-
72-
var element = $( "#tabs2" ).tabs();
73-
74-
element.one( "tabsbeforeload", function() {
75-
equal( element.find( ".ui-tabs-nav li:eq(2) em" ).length, 1, "beforeload" );
76-
});
77-
element.one( "tabsload", function() {
78-
// wait until after the load finishes before checking for the spinner to be removed
79-
setTimeout(function() {
80-
equal( element.find( ".ui-tabs-nav li:eq(2) em" ).length, 0, "load" );
81-
start();
82-
}, 1 );
83-
});
84-
element.tabs( "option", "active", 2 );
85-
});
86-
8769
module( "tabs (deprecated): events" );
8870

8971
asyncTest( "load", function() {

ui/jquery.ui.tabs.js

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -863,32 +863,6 @@ if ( $.uiBackCompat !== false ) {
863863
}
864864
});
865865

866-
// spinner
867-
$.widget( "ui.tabs", $.ui.tabs, {
868-
options: {
869-
spinner: "<em>Loading&#8230;</em>"
870-
},
871-
_create: function() {
872-
this._super();
873-
this._on({
874-
tabsbeforeload: function( event, ui ) {
875-
// Don't react to nested tabs or tabs that don't use a spinner
876-
if ( event.target !== this.element[ 0 ] ||
877-
!this.options.spinner ) {
878-
return;
879-
}
880-
881-
var span = ui.tab.find( "span" ),
882-
html = span.html();
883-
span.html( this.options.spinner );
884-
ui.jqXHR.complete(function() {
885-
span.html( html );
886-
});
887-
}
888-
});
889-
}
890-
});
891-
892866
// add/remove methods and events
893867
$.widget( "ui.tabs", $.ui.tabs, {
894868
options: {

0 commit comments

Comments
 (0)