Skip to content

Commit 9202bb7

Browse files
committed
Autocomplete: Removed data fallback for item.autocomplete. Fixes #8156 - Autocomplete: Remove data fallbacks.
1 parent 2582bfa commit 9202bb7

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

demos/autocomplete/combobox.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@
111111

112112
input.data( "autocomplete" )._renderItem = function( ul, item ) {
113113
return $( "<li>" )
114-
.data( "item.autocomplete", item )
115114
.append( "<a>" + item.label + "</a>" )
116115
.appendTo( ul );
117116
};

demos/autocomplete/custom-data.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@
6868
})
6969
.data( "autocomplete" )._renderItem = function( ul, item ) {
7070
return $( "<li>" )
71-
.data( "item.autocomplete", item )
7271
.append( "<a>" + item.label + "<br>" + item.desc + "</a>" )
7372
.appendTo( ul );
7473
};

ui/jquery.ui.autocomplete.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,7 @@ $.widget( "ui.autocomplete", {
237237
}
238238
}
239239

240-
// back compat for _renderItem using item.autocomplete, via #7810
241-
// TODO remove the fallback, see #8156
242-
var item = ui.item.data( "ui-autocomplete-item" ) || ui.item.data( "item.autocomplete" );
240+
var item = ui.item.data( "ui-autocomplete-item" );
243241
if ( false !== this._trigger( "focus", event, { item: item } ) ) {
244242
// use value to match what will end up in the input, if it was a key event
245243
if ( event.originalEvent && /^key/.test( event.originalEvent.type ) ) {
@@ -255,9 +253,7 @@ $.widget( "ui.autocomplete", {
255253
}
256254
},
257255
menuselect: function( event, ui ) {
258-
// back compat for _renderItem using item.autocomplete, via #7810
259-
// TODO remove the fallback, see #8156
260-
var item = ui.item.data( "ui-autocomplete-item" ) || ui.item.data( "item.autocomplete" ),
256+
var item = ui.item.data( "ui-autocomplete-item" ),
261257
previous = this.previous;
262258

263259
// only trigger when focus was lost (click on menu)

0 commit comments

Comments
 (0)