Skip to content

Commit 1e2c5ea

Browse files
committed
[css-scroll-snap] Mark merged/unmerged status of diffs
1 parent 4a09738 commit 1e2c5ea

File tree

1 file changed

+35
-11
lines changed

1 file changed

+35
-11
lines changed

css-scroll-snap/diff-notes.html

Lines changed: 35 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
margin: 2em 0 1em;
1313
}
1414

15+
dt > strong,
1516
ins, del {
1617
color: inherit;
1718
border-radius: 0.5em;
@@ -25,6 +26,10 @@
2526
.down::after { content: "⇓"; }
2627
.block { display: block; }
2728

29+
dt > strong {
30+
background: yellow;
31+
}
32+
2833
th {
2934
text-align: right;
3035
}
@@ -99,7 +104,7 @@ <h2>Suggested Process</h2>
99104
<h2>Specific Changes</h2>
100105

101106
<dl class="changes"l>
102-
<dt id=change-title>Title Change
107+
<dt id=change-title>Title Change <strong>Merged</strong>
103108
<dd>
104109
Robert O'Callahan requested a change to the name of the spec,
105110
because (with his requested changes)
@@ -111,7 +116,7 @@ <h2>Specific Changes</h2>
111116
<p>http://www.w3.org/TR/css-<del>snappoints</del><ins>scroll-snap</ins>-1/
112117
</blockquote>
113118

114-
<dt id=change-margin-area>Terminology Change: Scroll Snap Area
119+
<dt id=change-margin-area>Terminology Change: Scroll Snap Area <strong>Merged</strong>
115120
<dd>
116121
Tab and I introduced the term “scroll snap area”
117122
to refer to the rectangle being aligned within the viewport.
@@ -124,6 +129,7 @@ <h2>Specific Changes</h2>
124129
<pre>s/<del>scroll snap margin</del>/<ins>scroll snap area</ins>/g;</pre>
125130

126131
<dt id=change-margin-border-box>Error: border-box vs. margin-box
132+
<strong>Partially Merged</strong>
127133
<dd>
128134
Matt's spec parenthetically mentions that the scroll snap area defaults to the margin box. However, the spec actually defines that it defaults to the border box. This change corrects this error.
129135

@@ -134,7 +140,11 @@ <h2>Specific Changes</h2>
134140
within &hellip;
135141
</blockquote>
136142

143+
(In the most recent changes, “margin box” has been replaced with “border box”,
144+
but the resulting text is awkward.)
145+
137146
<dt id="change-physics">Move: Undefined Animations and Physics
147+
<strong>Merged</strong>
138148
<dd>
139149
There is a statement in the definition of <code>scroll-snap-type</code>
140150
that, since it applies generally to scroll-snapping,
@@ -147,6 +157,7 @@ <h2>Specific Changes</h2>
147157
</blockquote>
148158

149159
<dt id=change-axes>Specifying Scroll-snap Axes
160+
<strong>Partially Merged</strong>
150161
<dd>
151162
The WG <a href="https://www.w3.org/mid/CADhPm3t9_fcrr8mZ9eYzkghmkJ0pnmOK5_c10w6RAv51T-28AQ@mail.gmail.com">resolved on 2 December 2015</a>
152163
to specify, on a property applied to the scroll container, which axis(es) would be honored in scroll snapping.
@@ -203,6 +214,7 @@ <h2>Specific Changes</h2>
203214
on whether there should be longhands for this and if so, what the shorthand/longhand names should be.
204215

205216
<dt id=change-trap>Trapping
217+
<strong>Merged</strong>
206218
<dd>
207219
In Sapporo, the WG <a href="https://www.w3.org/mid/CADhPm3t9Y_L3sUAfmGXbVE7LdgYUcsDXpaRMXfXxxdkpKAtzWw@mail.gmail.com">resolved (27 October 2015)</a>
208220
to have non-<code>none</code> values of the <code>scroll-snap-type</code> property “trap” descendant scroll snap positions
@@ -270,6 +282,7 @@ <h2>Specific Changes</h2>
270282
</blockquote>
271283

272284
<dt id=change-rfc2119>RFC2119 Terminology
285+
<strong>Merged</strong>
273286
<dd>
274287
As much as I like the word “guarantee” in the description of <code>mandatory</code>,
275288
it seems more appropriate to use RFC2119’s “requirement”.
@@ -334,6 +347,7 @@ <h2>Specific Changes</h2>
334347
</ul>
335348

336349
<dt id=change-relxy>Clarification: Corresponding Dimensions
350+
<strong>Merged</strong>
337351
<dd>
338352
Clarify that percentages are calculated with respect to their corresponding dimensions.
339353
<blockquote>
@@ -347,6 +361,7 @@ <h2>Specific Changes</h2>
347361
</table>
348362
</blockquote>
349363
<dt id=change-animatable>Fix Animatable Lines
364+
<strong>Merged</strong>
350365
<dd>
351366
Fix the Animatable lines
352367
<blockquote>
@@ -372,6 +387,7 @@ <h2>Specific Changes</h2>
372387

373388

374389
<dt id=change-length-14>Defining the Scroll Snap Area
390+
<strong>Merged</strong>
375391
<dd>
376392
This wording explicitly hooks into the way <code>margin</code> and <code>border-image-outset</code> are defined,
377393
which ensures that the assignment of values is fully defined (by reference).
@@ -387,7 +403,9 @@ <h2>Specific Changes</h2>
387403
</dl>
388404
</del>
389405
</blockquote>
390-
<dt id=change-alignment>Definition of <code>scroll-snap-align</code>.
406+
407+
<dt id=change-alignment>Definition of <code>scroll-snap-align</code>
408+
<strong>Merged</strong>
391409
<dd>
392410
The following definition is more concise and more concrete,
393411
because it hooks into the proper terminology.
@@ -426,6 +444,7 @@ <h2>Specific Changes</h2>
426444
-->
427445

428446
<dt id=change-subheads>Descriptive Subheadings
447+
<strong>Merged</strong>
429448
<dd>
430449
Tab and I try to use the subheadings as a way of describing what happens,
431450
preferably using words other than those that appear in the property name itself.
@@ -444,6 +463,7 @@ <h2>Specific Changes</h2>
444463
</ul>
445464

446465
<dt id=change-terms>Inlining Definitions
466+
<strong>Merged</strong>
447467
<dd>
448468
While having a glossary appendix is sometimes nice,
449469
Tab and I tend to put the defining instance of terms inline in the prose:
@@ -512,13 +532,13 @@ <h2>Specific Changes</h2>
512532
<dd>
513533
The following rewordings are recommended, as they seem somewhat less awkward than the original wording:
514534
<ul type=a>
515-
<li>
535+
<li><strong>Merged</strong>
516536
This rewording is less grammatically complex, and maintains parallelism with the previous parenthetical.
517537
<blockquote>
518538
<p>Snap positions can be specified as a particular alignment (<code>scroll-snap-align</code>) of an element’s scroll snap area (its border bounding box, as modified by <code>scroll-snap-margin</code>) within the scroll container’s snapport
519539
(<del>the rectangle obtained by reducing its visual viewport</del> <ins>its visual viewport, as reduced by its scroll-snap-padding</ins>).
520540
</blockquote>
521-
<li>
541+
<li><strong>Merged</strong>
522542
This one drops the (in CSS specs) unnecessary “must”,
523543
and shifts the parenthetical to the end so it doesn't interrupt the connection between the adjective “nearest ancestor” and the noun it describes.
524544
<blockquote>
@@ -540,14 +560,14 @@ <h2>Specific Changes</h2>
540560
<blockquote>
541561
<p><ins>(</ins>If <del>no reachable snap position</del> <ins>none</ins> exist<del>s</del>, then no snapping occurs.<ins>)</ins></p>
542562
</blockquote>
543-
<li>
563+
<li><strong>Merged</strong>
544564
This rewording is more concise, but conveys the same thing.
545565
<blockquote>
546566
<p>The <a class="property" href="#propdef-scroll-snap-padding">scroll-snap-padding</a> property defines the <dfn id="scroll-snapport">scroll snapport</dfn><!--
547567
--><del>a region inset from the visual viewport of a <a href="#scroll-container">scroll container</a> used in calculating its <a href="#scroll-snap-position">snap positions</a>. The snapport is used as the alignment container when calculating <a href="#scroll-snap-position">snap positions</a>.</del>
548568
<ins>the area of the scrollport that is used as the <a href="https://drafts.csswg.org/css-align-3/#alignment-container">alignment container</a> of the <a href="#scroll-snap-area">scroll snap areas</a> when calculating their <a href="#scroll-snap-position">snap positions</a></ins>.
549569
</blockquote>
550-
<li>
570+
<li><strong>Merged</strong>
551571
The definition here is essentially redundant with the previous paragraph;
552572
Tab and I think this bit of text therefore doesn't need to exist.
553573
<blockquote>
@@ -556,15 +576,15 @@ <h2>Specific Changes</h2>
556576
<dd><del>Specifies the region inset from the visual viewport.</del> Values are interpreted as for <a class="property" href="https://drafts.csswg.org/css2/box.html#propdef-padding">padding</a>, and specify inward offsets from each edge of the visual viewport.
557577
</dl>
558578
</blockquote>
559-
<li>
579+
<li><strong>Merged</strong>
560580
This rewording is more concise, but conveys the same thing with as much precision.
561581
<blockquote>
562582
<p>The <a class="property" href="#propdef-scroll-snap-margin">scroll-snap-margin</a> property
563583
defines the <dfn id="scroll-snap-area">scroll snap area</dfn>
564584
<del>on elements within a <a href="#scroll-container">scroll container</a>, used in calculating <a href="#scroll-snap-position">snap positions</a> for that scroll container</del>
565585
<ins>that is used for snapping this box to the <a href="#scroll-snapport">snapport</a></ins>.
566586
</blockquote>
567-
<li>
587+
<li><strong>Merged</strong>
568588
This rewording uses terminology previously defined in order to present more concise definitions with simpler sentence structure:
569589
<blockquote>
570590
<p><ins>Values are defined as follows:</ins>
@@ -592,14 +612,16 @@ <h2>Specific Changes</h2>
592612
<blockquote>
593613
<p>&hellip the scroll container must not snap<ins>: all scroll positions are equally valid</ins>.
594614
</blockquote>
595-
<li>This phrase provides something a little more concrete for the reader to relate to, making it less necessary for a casual reader to follow the definition link for “snap” to figure out what that means:
615+
<li><strong>Merged</strong>
616+
This phrase provides something a little more concrete for the reader to relate to, making it less necessary for a casual reader to follow the definition link for “snap” to figure out what that means:
596617
<blockquote>
597618
<p>&hellip; the scroll container may snap <ins>to a valid snap position</ins> at the termination of a scroll &hellip;
598619
</blockquote>
599620
<blockquote>
600621
<p>&hellip; the scroll container is guaranteed to be snapped <ins>to a valid snap position</ins> when there are no active scrolling operations &hellip;
601622
</blockquote>
602-
<li>This comma breaks up a very long string of (4) prepositional phrases
623+
<li><strong>Merged</strong>
624+
This comma breaks up a very long string of (4) prepositional phrases
603625
by splitting off the UA discretion part:
604626
<blockquote>
605627
the scroll container may snap to a valid snap position at the termination of a scroll<ins>,</ins> at the discretion of the UA given the parameters of the scroll.
@@ -608,6 +630,7 @@ <h2>Specific Changes</h2>
608630
</dd>
609631

610632
<dt id=change-point>Point Snapping
633+
<strong>Merged</strong>
611634
<dd>
612635
While Tab and I can accept for point-snapping to be deferred to the next level,
613636
we would like for at least the next (fully complete) publication
@@ -653,6 +676,7 @@ <h3 class="heading settled" data-level="7.2" id="snap-dimensions"><span class="s
653676
Again, we're happy to leave this to level 2, but do want the feature design published for future reference.)
654677

655678
<dt id="change-ack">Acknowledgements Update
679+
<strong>Merged</strong>
656680
<dd>
657681
We've added a list of the people who have contributed the spec,
658682
and noted that their proposals were mostly accepted rather than mostly ignored.

0 commit comments

Comments
 (0)