Refactor repeated expression.

garydgregory · garydgregory · commit 058b9726a927 · 2012-03-16T20:41:26.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1301750 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/codec/binary/BaseNCodecInputStream.java b/src/main/java/org/apache/commons/codec/binary/BaseNCodecInputStream.java
@@ -54,7 +54,8 @@ public int read() throws IOException {
             r = read(singleByte, 0, 1);
         }
         if (r > 0) {
-            return singleByte[0] < 0 ? 256 + singleByte[0] : singleByte[0];
+            final byte b = singleByte[0];
+            return b < 0 ? 256 + b : b;
         }
         return -1;
     }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,8 @@ public int read() throws IOException {`
`54`	`54`	`r = read(singleByte, 0, 1);`
`55`	`55`	`}`
`56`	`56`	`if (r > 0) {`
`57`		`- return singleByte[0] < 0 ? 256 + singleByte[0] : singleByte[0];`
	`57`	`+ final byte b = singleByte[0];`
	`58`	`+ return b < 0 ? 256 + b : b;`
`58`	`59`	`}`
`59`	`60`	`return -1;`
`60`	`61`	`}`