Speed improvement for phonetic engine by implementing the suggested fixme.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1376661 13f79535-47bb-0310-9956-ffa450edef68

Author: netomi

src/main/java/org/apache/commons/codec/language/bm/Rule.java

@@ -617,13 +617,13 @@ public boolean patternAndContextMatches(CharSequence input, int i) {
             return false;
         }
 
-        // fixme: this is a readability/speed trade-off - these 3 expressions should be inlined for speed to avoid
-        // evaluating latter ones if earlier ones have already failed, but that would make the code a lot harder to
-        // read
-        boolean patternMatches = input.subSequence(i, ipl).equals(this.pattern);
-        boolean rContextMatches = this.rContext.isMatch(input.subSequence(ipl, input.length()));
-        boolean lContextMatches = this.lContext.isMatch(input.subSequence(0, i));
-
-        return patternMatches && rContextMatches && lContextMatches;
+        // evaluate the pattern, left context and right context
+        // fail early if any of the evaluations is not successful
+        if (!input.subSequence(i, ipl).equals(this.pattern)) {
+            return false;
+        } else if (!this.rContext.isMatch(input.subSequence(ipl, input.length()))) {
+            return false;
+        }
+        return this.lContext.isMatch(input.subSequence(0, i));
     }
 }