Use final on some lvars to clarify intent and avoid potential bugs. Should final be applied all over?

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1378966 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/main/java/org/apache/commons/codec/binary/Base32.java

@@ -289,15 +289,15 @@ void decode(byte[] in, int inPos, int inAvail, Context context) { // package pro
             context.eof = true;
         }
         for (int i = 0; i < inAvail; i++) {
-            byte b = in[inPos++];
+            final byte b = in[inPos++];
             if (b == PAD) {
                 // We're done.
                 context.eof = true;
                 break;
             } else {
                 final byte[] buffer = ensureBufferSize(decodeSize, context);
                 if (b >= 0 && b < this.decodeTable.length) {
-                    int result = this.decodeTable[b];
+                    final int result = this.decodeTable[b];
                     if (result >= 0) {
                         context.modulus = (context.modulus+1) % BYTES_PER_ENCODED_BLOCK;
                         // collect decoded bytes
@@ -384,7 +384,7 @@ void encode(byte[] in, int inPos, int inAvail, Context context) { // package pro
                 return; // no leftovers to process and not using chunking
             }
             final byte[] buffer = ensureBufferSize(encodeSize, context);
-            int savedPos = context.pos;
+            final int savedPos = context.pos;
             switch (context.modulus) { // % 5
                 case 1 : // Only 1 octet; take top 5 bits then remainder
                     buffer[context.pos++] = encodeTable[(int)(context.lbitWorkArea >> 3) & MASK_5BITS]; // 8-1*5 = 3

src/main/java/org/apache/commons/codec/binary/Base64.java

@@ -335,7 +335,7 @@ void encode(byte[] in, int inPos, int inAvail, Context context) {
                 return; // no leftovers to process and not using chunking
             }
             final byte[] buffer = ensureBufferSize(encodeSize, context);
-            int savedPos = context.pos;
+            final int savedPos = context.pos;
             switch (context.modulus) { // 0-2
                 case 1 : // 8 bits = 6 + 2
                     // top 6 bits: