Use final.

Author: Gary Gregory

src/main/java/org/apache/commons/codec/binary/Base32.java

@@ -557,7 +557,7 @@ public boolean isInAlphabet(final byte octet) {
      *
      * @throws IllegalArgumentException if the bits being checked contain any non-zero value
      */
-    private void validateCharacter(int numBits, Context context) {
+    private void validateCharacter(final int numBits, final Context context) {
         if ((context.lbitWorkArea & numBits) != 0) {
             throw new IllegalArgumentException(
                 "Last encoded character (before the paddings if any) is a valid base 32 alphabet but not a possible value");

src/main/java/org/apache/commons/codec/binary/Base64.java

@@ -793,7 +793,7 @@ protected boolean isInAlphabet(final byte octet) {
      *
      * @throws IllegalArgumentException if the bits being checked contain any non-zero value
      */
-    private long validateCharacter(int numBitsToDrop, Context context) {
+    private long validateCharacter(final int numBitsToDrop, final Context context) {
         if ((context.ibitWorkArea & numBitsToDrop) != 0) {
         throw new IllegalArgumentException(
             "Last encoded character (before the paddings if any) is a valid base 64 alphabet but not a possible value");

src/main/java/org/apache/commons/codec/digest/MurmurHash2.java

@@ -48,15 +48,15 @@ private MurmurHash2() {
 	 * @param seed   initial seed value
 	 * @return 32 bit hash of the given array
 	 */
-	public static int hash32(final byte[] data, int length, int seed) {
+	public static int hash32(final byte[] data, final int length, final int seed) {
 		// 'm' and 'r' are mixing constants generated offline.
 		// They're not really 'magic', they just happen to work well.
 		final int m = 0x5bd1e995;
 		final int r = 24;
 
 		// Initialize the hash to a random value
 		int h = seed ^ length;
-		int length4 = length / 4;
+		final int length4 = length / 4;
 
 		for (int i = 0; i < length4; i++) {
 			final int i4 = i * 4;
@@ -94,7 +94,7 @@ public static int hash32(final byte[] data, int length, int seed) {
 	 * @param length length of the array to hash
 	 * @return 32 bit hash of the given array
 	 */
-	public static int hash32(final byte[] data, int length) {
+	public static int hash32(final byte[] data, final int length) {
 		return hash32(data, length, 0x9747b28c);
 	}
 
@@ -117,7 +117,7 @@ public static int hash32(final String text) {
 	 * @param length length of the substring to hash
 	 * @return 32 bit hash of the given string
 	 */
-	public static int hash32(final String text, int from, int length) {
+	public static int hash32(final String text, final int from, final int length) {
 		return hash32(text.substring(from, from + length));
 	}
 
@@ -129,13 +129,13 @@ public static int hash32(final String text, int from, int length) {
 	 * @param seed   initial seed value
 	 * @return 64 bit hash of the given array
 	 */
-	public static long hash64(final byte[] data, int length, int seed) {
+	public static long hash64(final byte[] data, final int length, final int seed) {
 		final long m = 0xc6a4a7935bd1e995L;
 		final int r = 47;
 
 		long h = (seed & 0xffffffffl) ^ (length * m);
 
-		int length8 = length / 8;
+		final int length8 = length / 8;
 
 		for (int i = 0; i < length8; i++) {
 			final int i8 = i * 8;
@@ -184,7 +184,7 @@ public static long hash64(final byte[] data, int length, int seed) {
 	 * @param length length of the array to hash
 	 * @return 64 bit hash of the given string
 	 */
-	public static long hash64(final byte[] data, int length) {
+	public static long hash64(final byte[] data, final int length) {
 		return hash64(data, length, 0xe17a1465);
 	}
 
@@ -207,7 +207,7 @@ public static long hash64(final String text) {
 	 * @param length length of the substring to hash
 	 * @return 64 bit hash of the given array
 	 */
-	public static long hash64(final String text, int from, int length) {
+	public static long hash64(final String text, final int from, final int length) {
 		return hash64(text.substring(from, from + length));
 	}
 }

src/main/java/org/apache/commons/codec/digest/MurmurHash3.java

@@ -86,7 +86,7 @@ private MurmurHash3() {
 	 * @param l1 long to hash
 	 * @return 32 bit hash
 	 */
-	public static int hash32(long l0, long l1) {
+	public static int hash32(final long l0, final long l1) {
 		return hash32(l0, l1, DEFAULT_SEED);
 	}
 
@@ -96,7 +96,7 @@ public static int hash32(long l0, long l1) {
 	 * @param l0 long to hash
 	 * @return 32 bit hash
 	 */
-	public static int hash32(long l0) {
+	public static int hash32(final long l0) {
 		return hash32(l0, DEFAULT_SEED);
 	}
 
@@ -107,7 +107,7 @@ public static int hash32(long l0) {
 	 * @param seed initial seed value
 	 * @return 32 bit hash
 	 */
-	public static int hash32(long l0, int seed) {
+	public static int hash32(final long l0, final int seed) {
 		int hash = seed;
 		final long r0 = Long.reverseBytes(l0);
 
@@ -125,7 +125,7 @@ public static int hash32(long l0, int seed) {
 	 * @param seed initial seed value
 	 * @return 32 bit hash
 	 */
-	public static int hash32(long l0, long l1, int seed) {
+	public static int hash32(final long l0, final long l1, final int seed) {
 		int hash = seed;
 		final long r0 = Long.reverseBytes(l0);
 		final long r1 = Long.reverseBytes(l1);
@@ -144,7 +144,7 @@ public static int hash32(long l0, long l1, int seed) {
 	 * @param data - input byte array
 	 * @return 32 bit hash
 	 */
-	public static int hash32(byte[] data) {
+	public static int hash32(final byte[] data) {
 		return hash32(data, 0, data.length, DEFAULT_SEED);
 	}
 
@@ -154,8 +154,8 @@ public static int hash32(byte[] data) {
 	 * @param data - input string
 	 * @return 32 bit hash
 	 */
-	public static int hash32(String data) {
-		byte[] origin = data.getBytes();
+	public static int hash32(final String data) {
+		final byte[] origin = data.getBytes();
 		return hash32(origin, 0, origin.length, DEFAULT_SEED);
 	}
 
@@ -166,7 +166,7 @@ public static int hash32(String data) {
 	 * @param length - length of array
 	 * @return 32 bit hash
 	 */
-	public static int hash32(byte[] data, int length) {
+	public static int hash32(final byte[] data, final int length) {
 		return hash32(data, length, DEFAULT_SEED);
 	}
 
@@ -178,7 +178,7 @@ public static int hash32(byte[] data, int length) {
 	 * @param seed   - seed. (default 0)
 	 * @return 32 bit hash
 	 */
-	public static int hash32(byte[] data, int length, int seed) {
+	public static int hash32(final byte[] data, final int length, final int seed) {
 		return hash32(data, 0, length, seed);
 	}
 
@@ -191,21 +191,21 @@ public static int hash32(byte[] data, int length, int seed) {
 	 * @param seed   - seed. (default 0)
 	 * @return 32 bit hash
 	 */
-	public static int hash32(byte[] data, int offset, int length, int seed) {
+	public static int hash32(final byte[] data, final int offset, final int length, final int seed) {
 		int hash = seed;
 		final int nblocks = length >> 2;
 
 		// body
 		for (int i = 0; i < nblocks; i++) {
-			int i_4 = i << 2;
-			int k = (data[offset + i_4] & 0xff) | ((data[offset + i_4 + 1] & 0xff) << 8)
+			final int i_4 = i << 2;
+			final int k = (data[offset + i_4] & 0xff) | ((data[offset + i_4 + 1] & 0xff) << 8)
 					| ((data[offset + i_4 + 2] & 0xff) << 16) | ((data[offset + i_4 + 3] & 0xff) << 24);
 
 			hash = mix32(k, hash);
 		}
 
 		// tail
-		int idx = nblocks << 2;
+		final int idx = nblocks << 2;
 		int k1 = 0;
 		switch (length - idx) {
 		case 3:
@@ -232,7 +232,7 @@ public static int hash32(byte[] data, int offset, int length, int seed) {
 	 * @param data - input byte array
 	 * @return 64 bit hash
 	 */
-	public static long hash64(byte[] data) {
+	public static long hash64(final byte[] data) {
 		return hash64(data, 0, data.length, DEFAULT_SEED);
 	}
 
@@ -243,10 +243,10 @@ public static long hash64(byte[] data) {
 	 * @param data - input long
 	 * @return 64 bit hash
 	 */
-	public static long hash64(long data) {
+	public static long hash64(final long data) {
 		long hash = DEFAULT_SEED;
 		long k = Long.reverseBytes(data);
-		int length = LONG_BYTES;
+		final int length = LONG_BYTES;
 		// mix functions
 		k *= C1;
 		k = Long.rotateLeft(k, R1);
@@ -266,9 +266,9 @@ public static long hash64(long data) {
 	 * @param data - input int
 	 * @return 64 bit hash
 	 */
-	public static long hash64(int data) {
+	public static long hash64(final int data) {
 		long k1 = Integer.reverseBytes(data) & (-1L >>> 32);
-		int length = INTEGER_BYTES;
+		final int length = INTEGER_BYTES;
 		long hash = DEFAULT_SEED;
 		k1 *= C1;
 		k1 = Long.rotateLeft(k1, R1);
@@ -287,7 +287,7 @@ public static long hash64(int data) {
 	 * @param data - input short
 	 * @return 64 bit hash
 	 */
-	public static long hash64(short data) {
+	public static long hash64(final short data) {
 		long hash = DEFAULT_SEED;
 		long k1 = 0;
 		k1 ^= ((long) data & 0xff) << 8;
@@ -312,7 +312,7 @@ public static long hash64(short data) {
 	 * @param length - length of array
 	 * @return 64 bit hash
 	 */
-	public static long hash64(byte[] data, int offset, int length) {
+	public static long hash64(final byte[] data, final int offset, final int length) {
 		return hash64(data, offset, length, DEFAULT_SEED);
 	}
 
@@ -325,7 +325,7 @@ public static long hash64(byte[] data, int offset, int length) {
 	 * @param seed   - seed. (default 0)
 	 * @return 64 bit hash
 	 */
-	public static long hash64(byte[] data, int offset, int length, int seed) {
+	public static long hash64(final byte[] data, final int offset, final int length, final int seed) {
 		long hash = seed;
 		final int nblocks = length >> 3;
 
@@ -347,7 +347,7 @@ public static long hash64(byte[] data, int offset, int length, int seed) {
 
 		// tail
 		long k1 = 0;
-		int tailStart = nblocks << 3;
+		final int tailStart = nblocks << 3;
 		switch (length - tailStart) {
 		case 7:
 			k1 ^= ((long) data[offset + tailStart + 6] & 0xff) << 48;
@@ -382,7 +382,7 @@ public static long hash64(byte[] data, int offset, int length, int seed) {
 	 * @param data - input byte array
 	 * @return - 128 bit hash (2 longs)
 	 */
-	public static long[] hash128(byte[] data) {
+	public static long[] hash128(final byte[] data) {
 		return hash128(data, 0, data.length, DEFAULT_SEED);
 	}
 
@@ -392,8 +392,8 @@ public static long[] hash128(byte[] data) {
 	 * @param data - input String
 	 * @return - 128 bit hash (2 longs)
 	 */
-	public static long[] hash128(String data) {
-		byte[] origin = data.getBytes();
+	public static long[] hash128(final String data) {
+		final byte[] origin = data.getBytes();
 		return hash128(origin, 0, origin.length, DEFAULT_SEED);
 	}
 
@@ -406,7 +406,7 @@ public static long[] hash128(String data) {
 	 * @param seed   - seed. (default is 0)
 	 * @return - 128 bit hash (2 longs)
 	 */
-	public static long[] hash128(byte[] data, int offset, int length, int seed) {
+	public static long[] hash128(final byte[] data, final int offset, final int length, final int seed) {
 		long h1 = seed;
 		long h2 = seed;
 		final int nblocks = length >> 4;
@@ -446,7 +446,7 @@ public static long[] hash128(byte[] data, int offset, int length, int seed) {
 		// tail
 		long k1 = 0;
 		long k2 = 0;
-		int tailStart = nblocks << 4;
+		final int tailStart = nblocks << 4;
 		switch (length - tailStart) {
 		case 15:
 			k2 ^= (long) (data[offset + tailStart + 14] & 0xff) << 48;
@@ -513,7 +513,7 @@ private static int mix32(int k, int hash) {
 		return Integer.rotateLeft(hash, R2_32) * M_32 + N_32;
 	}
 
-	private static int fmix32(int length, int hash) {
+	private static int fmix32(final int length, int hash) {
 		hash ^= length;
 		hash ^= (hash >>> 16);
 		hash *= 0x85ebca6b;
@@ -539,12 +539,12 @@ public static class IncrementalHash32 {
 		int totalLen;
 		int hash;
 
-		public final void start(int hash) {
+		public final void start(final int hash) {
 			tailLen = totalLen = 0;
 			this.hash = hash;
 		}
 
-		public final void add(byte[] data, int offset, int length) {
+		public final void add(final byte[] data, int offset, final int length) {
 			if (length == 0) {
                 return;
             }
@@ -578,12 +578,12 @@ public final void add(byte[] data, int offset, int length) {
 				hash ^= k;
 				hash = Integer.rotateLeft(hash, R2_32) * M_32 + N_32;
 			}
-			int length2 = length - offset2;
+			final int length2 = length - offset2;
 			offset += offset2;
 			final int nblocks = length2 >> 2;
 
 			for (int i = 0; i < nblocks; i++) {
-				int i_4 = (i << 2) + offset;
+				final int i_4 = (i << 2) + offset;
 				int k = orBytes(data[i_4], data[i_4 + 1], data[i_4 + 2], data[i_4 + 3]);
 
 				// mix functions
@@ -594,7 +594,7 @@ public final void add(byte[] data, int offset, int length) {
 				hash = Integer.rotateLeft(hash, R2_32) * M_32 + N_32;
 			}
 
-			int consumed = (nblocks << 2);
+			final int consumed = (nblocks << 2);
 			tailLen = length2 - consumed;
 			if (consumed == length2) {
                 return;
@@ -630,7 +630,7 @@ public final int end() {
 		}
 	}
 
-	private static int orBytes(byte b1, byte b2, byte b3, byte b4) {
+	private static int orBytes(final byte b1, final byte b2, final byte b3, final byte b4) {
 		return (b1 & 0xff) | ((b2 & 0xff) << 8) | ((b3 & 0xff) << 16) | ((b4 & 0xff) << 24);
 	}
 }

src/main/java/org/apache/commons/codec/digest/Sha2Crypt.java

@@ -133,7 +133,7 @@ public static String sha256Crypt(final byte[] keyBytes, String salt) {
      *             when a {@link java.security.NoSuchAlgorithmException} is caught.
      * @since 1.12
      */
-    public static String sha256Crypt(final byte[] keyBytes, String salt, Random random) {
+    public static String sha256Crypt(final byte[] keyBytes, String salt, final Random random) {
         if (salt == null) {
             salt = SHA256_PREFIX + B64.getRandomSalt(8, random);
         }

src/main/java/org/apache/commons/codec/language/ColognePhonetic.java

@@ -309,7 +309,7 @@ private static boolean arrayContains(final char[] arr, final char key) {
      * @param text The source text to encode
      * @return the corresponding encoding according to the <i>K&ouml;lner Phonetik</i> algorithm
      */
-    public String colognePhonetic(String text) {
+    public String colognePhonetic(final String text) {
         if (text == null) {
             return null;
         }
@@ -414,7 +414,7 @@ public boolean isEncodeEqual(final String text1, final String text2) {
      * <li>small sharp s, German</li>
      * </ul>
      */
-    private char[] preprocess(String text) {
+    private char[] preprocess(final String text) {
         // This converts German small sharp s (Eszett) to SS
         final char[] chrs = text.toUpperCase(Locale.GERMAN).toCharArray();