Skip to content

Commit 3eef2f7

Browse files
committed
[CODEC-246] ColognePhoneticTest.testIsEncodeEquals missing assertions.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1832450 13f79535-47bb-0310-9956-ffa450edef68
1 parent 8d6b7fb commit 3eef2f7

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import org.apache.commons.codec.EncoderException;
2121
import org.apache.commons.codec.StringEncoderAbstractTest;
22+
import org.junit.Assert;
2223
import org.junit.Test;
2324

2425
/**
@@ -142,7 +143,10 @@ public void testIsEncodeEquals() {
142143
{"ganz", "G\u00e4nse"}, // Gänse
143144
{"Miyagi", "Miyako"}};
144145
for (final String[] element : data) {
145-
this.getStringEncoder().isEncodeEqual(element[1], element[0]);
146+
// This just compares and only shows we do not blow up
147+
final boolean encodeEqual = this.getStringEncoder().isEncodeEqual(element[1], element[0]);
148+
// Fails for https://issues.apache.org/jira/browse/CODEC-246
149+
// Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
146150
}
147151
}
148152

0 commit comments

Comments
 (0)