Skip to content

Commit 54f7ca3

Browse files
committed
Add edge case tests (which may not make sense, I need to check with Matthew)
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1152651 13f79535-47bb-0310-9956-ffa450edef68
1 parent 377691c commit 54f7ca3

1 file changed

Lines changed: 35 additions & 1 deletion

File tree

src/test/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java

Lines changed: 35 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.apache.commons.codec.StringEncoder;
2626
import org.apache.commons.codec.StringEncoderAbstractTest;
2727
import org.junit.Assert;
28+
import org.junit.Ignore;
2829
import org.junit.Test;
2930

3031
/**
@@ -34,19 +35,52 @@
3435
* @since 2.0
3536
*/
3637
public class BeiderMorseEncoderTest extends StringEncoderAbstractTest {
38+
private void assertNotEmpty(BeiderMorseEncoder bmpm, final String value) throws EncoderException {
39+
Assert.assertFalse(value, bmpm.encode(value).equals(""));
40+
}
41+
3742
@Override
3843
protected StringEncoder createStringEncoder() {
3944
return new BeiderMorseEncoder();
4045
}
4146

47+
@Ignore
48+
@Test
49+
public void testAsciiEncodeNotEmpty1Letter() throws EncoderException {
50+
BeiderMorseEncoder bmpm = new BeiderMorseEncoder();
51+
bmpm.setNameType(NameType.GENERIC);
52+
bmpm.setRuleType(RuleType.APPROX);
53+
for (char c = 'a'; c <= 'z'; c++) {
54+
final String value = "" + c;
55+
final String valueU = value.toUpperCase();
56+
assertNotEmpty(bmpm, value);
57+
assertNotEmpty(bmpm, valueU);
58+
}
59+
}
60+
61+
@Test
62+
public void testAsciiEncodeNotEmpty2Letters() throws EncoderException {
63+
BeiderMorseEncoder bmpm = new BeiderMorseEncoder();
64+
bmpm.setNameType(NameType.GENERIC);
65+
bmpm.setRuleType(RuleType.APPROX);
66+
for (char c1 = 'a'; c1 <= 'z'; c1++) {
67+
for (char c2 = 'a'; c2 <= 'z'; c2++) {
68+
final String value = new String(new char[] { c1, c2 });
69+
final String valueU = value.toUpperCase();
70+
assertNotEmpty(bmpm, value);
71+
assertNotEmpty(bmpm, valueU);
72+
}
73+
}
74+
}
75+
4276
@Test
4377
public void testEncodeAtzNotEmpty() throws EncoderException {
4478
BeiderMorseEncoder bmpm = new BeiderMorseEncoder();
4579
bmpm.setNameType(NameType.GENERIC);
4680
bmpm.setRuleType(RuleType.APPROX);
4781
String[] names = { "ácz", "átz", "Ignácz", "Ignátz", "Ignác" };
4882
for (String name : names) {
49-
Assert.assertFalse(bmpm.encode(name).equals(""));
83+
assertNotEmpty(bmpm, name);
5084
}
5185
}
5286

0 commit comments

Comments
 (0)