Skip to content

Commit 554058f

Browse files
committed
Fix findbugs warnings.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1380304 13f79535-47bb-0310-9956-ffa450edef68
1 parent e0c569d commit 554058f

3 files changed

Lines changed: 1 addition & 8 deletions

File tree

src/main/java/org/apache/commons/codec/language/bm/Lang.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,9 @@ public static Lang loadFromResource(String languageRulesResourceName, Languages
141141
String line = rawLine;
142142

143143
if (inExtendedComment) {
144+
// check for closing comment marker, otherwise discard doc comment line
144145
if (line.endsWith(ResourceConstants.EXT_CMT_END)) {
145146
inExtendedComment = false;
146-
} else {
147-
// discard doc comment line
148147
}
149148
} else {
150149
if (line.startsWith(ResourceConstants.EXT_CMT_START)) {

src/main/java/org/apache/commons/codec/language/bm/Languages.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,16 +164,12 @@ public static Languages getInstance(String languagesResourceName) {
164164
if (inExtendedComment) {
165165
if (line.endsWith(ResourceConstants.EXT_CMT_END)) {
166166
inExtendedComment = false;
167-
} else {
168-
// skip
169167
}
170168
} else {
171169
if (line.startsWith(ResourceConstants.EXT_CMT_START)) {
172170
inExtendedComment = true;
173171
} else if (line.length() > 0) {
174172
ls.add(line);
175-
} else {
176-
// skip blank lines
177173
}
178174
}
179175
}

src/main/java/org/apache/commons/codec/language/bm/Rule.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,8 +334,6 @@ private static List<Rule> parseRules(final Scanner scanner, final String locatio
334334
if (inMultilineComment) {
335335
if (line.endsWith(ResourceConstants.EXT_CMT_END)) {
336336
inMultilineComment = false;
337-
} else {
338-
// skip
339337
}
340338
} else {
341339
if (line.startsWith(ResourceConstants.EXT_CMT_START)) {

0 commit comments

Comments
 (0)