[CODEC-150] Remove unnecessary call to Math.abs().

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1379806 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/changes/changes.xml

@@ -51,6 +51,9 @@ The <action> type attribute can be add,update,fix,remove.
     </release>
     -->
     <release version="1.7" date="TBD" description="Feature and fix release.">
+      <action issue="CODEC-150" dev="ggregory" type="add" due-to="lathspell">
+        Remove unnecessary call to Math.abs().
+      </action>
       <action issue="CODEC-151" dev="ggregory" type="add" due-to="lathspell">
         Remove unnecessary attempt to fill up the salt variable in UnixCrypt.
       </action>

src/main/java/org/apache/commons/codec/digest/UnixCrypt.java

@@ -239,8 +239,8 @@ public static String crypt(byte[] original, String salt) {
             Random randomGenerator = new Random();
             int numSaltChars = SALT_CHARS.length;
             // Types casts fix two FindBugs report of RV_ABSOLUTE_VALUE_OF_RANDOM_INT.
-            salt = "" + SALT_CHARS[(int)Math.abs((long)randomGenerator.nextInt()) % numSaltChars] +
-                   SALT_CHARS[(int)Math.abs((long)randomGenerator.nextInt()) % numSaltChars];
+            salt = "" + SALT_CHARS[randomGenerator.nextInt(numSaltChars)] +
+                   SALT_CHARS[randomGenerator.nextInt(numSaltChars)];
         } else if (!salt.matches("^[" + B64.B64T + "]{2,}$")) {
             throw new IllegalArgumentException("Invalid salt value: " + salt);
         }