[CODEC-110] Add a String version of Base64.isArrayByteBase64(). https://issues.apache.org/jira/browse/CODEC-110

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1063100 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/java/org/apache/commons/codec/binary/Base64.java

@@ -589,6 +589,20 @@ public static boolean isBase64(byte octet) {
         return octet == PAD || (octet >= 0 && octet < DECODE_TABLE.length && DECODE_TABLE[octet] != -1);
     }
 
+    /**
+     * Tests a given String to see if it contains only valid characters within the Base64 alphabet. Currently the
+     * method treats whitespace as valid.
+     * 
+     * @param base64
+     *            String to test
+     * @return <code>true</code> if all characters in the String are valid characters in the Base64 alphabet or if
+     *         the String is empty; <code>false</code>, otherwise
+     *  @since 1.5
+     */
+    public static boolean isBase64(String base64) {
+        return isArrayByteBase64(StringUtils.getBytesUtf8(base64));
+    }
+
     /**
      * Tests a given byte array to see if it contains only valid characters within the Base64 alphabet. Currently the
      * method treats whitespace as valid.
@@ -606,19 +620,6 @@ public static boolean isArrayByteBase64(byte[] arrayOctet) {
         }
         return true;
     }
-
-    /**
-     * Tests a given String to see if it contains only valid characters within the Base64 alphabet. Currently the
-     * method treats whitespace as valid.
-     * 
-     * @param base64
-     *            String of (presumably) base64 characters to test
-     * @return <code>true</code> if all characters in the String are valid characters in the Base64 alphabet or if
-     *         the String is empty; false, otherwise
-     */
-    public static boolean isStringBase64(String base64) {
-        return isArrayByteBase64(StringUtils.getBytesUtf8(base64));
-    }
 
     /**
      * Tests a given byte array to see if it contains only valid characters within the Base64 alphabet.

src/test/org/apache/commons/codec/binary/Base64Test.java

@@ -65,15 +65,15 @@ public void testIsStringBase64() {
         String invalidString = validString + ((char)0); // append null character
 
         try {
-            Base64.isStringBase64(nullString);
+            Base64.isBase64(nullString);
             fail("Base64.isStringBase64() should not be null-safe.");
         } catch (NullPointerException npe) {
             assertNotNull("Base64.isStringBase64() should not be null-safe.", npe);
         }
 
-        assertTrue("Base64.isStringBase64(empty-string) is true", Base64.isStringBase64(emptyString));
-        assertTrue("Base64.isStringBase64(valid-string) is true", Base64.isStringBase64(validString));        
-        assertFalse("Base64.isStringBase64(invalid-string) is false", Base64.isStringBase64(invalidString));        
+        assertTrue("Base64.isStringBase64(empty-string) is true", Base64.isBase64(emptyString));
+        assertTrue("Base64.isStringBase64(valid-string) is true", Base64.isBase64(validString));        
+        assertFalse("Base64.isStringBase64(invalid-string) is false", Base64.isBase64(invalidString));        
     }
 
     /**