Use final where possible.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1429868 13f79535-47bb-0310-9956-ffa450edef68

Author: garydgregory

src/main/java/org/apache/commons/codec/Charsets.java

@@ -70,7 +70,7 @@ public class Charsets {
      *            A charset or null.
      * @return the given Charset or the default Charset if the given Charset is null
      */
-    public static Charset toCharset(Charset charset) {
+    public static Charset toCharset(final Charset charset) {
         return charset == null ? Charset.defaultCharset() : charset;
     }
 
@@ -83,7 +83,7 @@ public static Charset toCharset(Charset charset) {
      * @throws java.nio.charset.UnsupportedCharsetException
      *             If the named charset is unavailable
      */
-    public static Charset toCharset(String charset) {
+    public static Charset toCharset(final String charset) {
         return charset == null ? Charset.defaultCharset() : Charset.forName(charset);
     }
 

src/main/java/org/apache/commons/codec/DecoderException.java

@@ -49,7 +49,7 @@ public DecoderException() {
      * @param message
      *            The detail message which is saved for later retrieval by the {@link #getMessage()} method.
      */
-    public DecoderException(String message) {
+    public DecoderException(final String message) {
         super(message);
     }
 
@@ -66,7 +66,7 @@ public DecoderException(String message) {
      *            value is permitted, and indicates that the cause is nonexistent or unknown.
      * @since 1.4
      */
-    public DecoderException(String message, Throwable cause) {
+    public DecoderException(final String message, final Throwable cause) {
         super(message, cause);
     }
 
@@ -80,7 +80,7 @@ public DecoderException(String message, Throwable cause) {
      *            value is permitted, and indicates that the cause is nonexistent or unknown.
      * @since 1.4
      */
-    public DecoderException(Throwable cause) {
+    public DecoderException(final Throwable cause) {
         super(cause);
     }
 }

src/main/java/org/apache/commons/codec/StringEncoderComparator.java

@@ -52,7 +52,7 @@ public StringEncoderComparator() {
      * @param stringEncoder
      *            the StringEncoder used for comparisons.
      */
-    public StringEncoderComparator(StringEncoder stringEncoder) {
+    public StringEncoderComparator(final StringEncoder stringEncoder) {
         this.stringEncoder = stringEncoder;
     }
 
@@ -70,15 +70,15 @@ public StringEncoderComparator(StringEncoder stringEncoder) {
      * @see Comparable
      */
     @Override
-    public int compare(Object o1, Object o2) {
+    public int compare(final Object o1, final Object o2) {
 
         int compareCode = 0;
 
         try {
-            Comparable s1 = (Comparable) this.stringEncoder.encode(o1);
-            Comparable s2 = (Comparable) this.stringEncoder.encode(o2);
+            final Comparable s1 = (Comparable) this.stringEncoder.encode(o1);
+            final Comparable s2 = (Comparable) this.stringEncoder.encode(o2);
             compareCode = s1.compareTo(s2);
-        } catch (EncoderException ee) {
+        } catch (final EncoderException ee) {
             compareCode = 0;
         }
         return compareCode;

src/main/java/org/apache/commons/codec/binary/Base32.java

@@ -166,7 +166,7 @@ public Base32() {
      * </p>
      * @param useHex if {@code true} then use Base32 Hex alphabet
      */
-    public Base32(boolean useHex) {
+    public Base32(final boolean useHex) {
         this(0, null, useHex);
     }
 
@@ -181,7 +181,7 @@ public Base32(boolean useHex) {
      *            8). If lineLength <= 0, then the output will not be divided into lines (chunks). Ignored when
      *            decoding.
      */
-    public Base32(int lineLength) {
+    public Base32(final int lineLength) {
         this(lineLength, CHUNK_SEPARATOR);
     }
 
@@ -203,7 +203,7 @@ public Base32(int lineLength) {
      * @throws IllegalArgumentException
      *             The provided lineSeparator included some Base32 characters. That's not going to work!
      */
-    public Base32(int lineLength, byte[] lineSeparator) {
+    public Base32(final int lineLength, final byte[] lineSeparator) {
         this(lineLength, lineSeparator, false);
     }
 
@@ -228,7 +228,7 @@ public Base32(int lineLength, byte[] lineSeparator) {
      *             The provided lineSeparator included some Base32 characters. That's not going to work! Or the
      *             lineLength > 0 and lineSeparator is null.
      */
-    public Base32(int lineLength, byte[] lineSeparator, boolean useHex) {
+    public Base32(final int lineLength, final byte[] lineSeparator, final boolean useHex) {
         super(BYTES_PER_UNENCODED_BLOCK, BYTES_PER_ENCODED_BLOCK,
                 lineLength,
                 lineSeparator == null ? 0 : lineSeparator.length);
@@ -245,7 +245,7 @@ public Base32(int lineLength, byte[] lineSeparator, boolean useHex) {
             }
             // Must be done after initializing the tables
             if (containsAlphabetOrPad(lineSeparator)) {
-                String sep = StringUtils.newStringUtf8(lineSeparator);
+                final String sep = StringUtils.newStringUtf8(lineSeparator);
                 throw new IllegalArgumentException("lineSeparator must not contain Base32 characters: [" + sep + "]");
             }
             this.encodeSize = BYTES_PER_ENCODED_BLOCK + lineSeparator.length;
@@ -281,7 +281,7 @@ public Base32(int lineLength, byte[] lineSeparator, boolean useHex) {
      * Output is written to {@link Context#buffer} as 8-bit octets, using {@link Context#pos} as the buffer position
      */
     @Override
-    void decode(byte[] in, int inPos, int inAvail, Context context) { // package protected for access from I/O streams
+    void decode(final byte[] in, int inPos, final int inAvail, final Context context) { // package protected for access from I/O streams
         if (context.eof) {
             return;
         }
@@ -375,7 +375,7 @@ void decode(byte[] in, int inPos, int inAvail, Context context) { // package pro
      * @param context the context to be used
      */
     @Override
-    void encode(byte[] in, int inPos, int inAvail, Context context) { // package protected for access from I/O streams
+    void encode(final byte[] in, int inPos, final int inAvail, final Context context) { // package protected for access from I/O streams
         if (context.eof) {
             return;
         }
@@ -477,7 +477,7 @@ void encode(byte[] in, int inPos, int inAvail, Context context) { // package pro
      * @return {@code true} if the value is defined in the the Base32 alphabet {@code false} otherwise.
      */
     @Override
-    public boolean isInAlphabet(byte octet) {
+    public boolean isInAlphabet(final byte octet) {
         return octet >= 0 && octet < decodeTable.length && decodeTable[octet] != -1;
     }
 }

src/main/java/org/apache/commons/codec/binary/Base32InputStream.java

@@ -44,7 +44,7 @@ public class Base32InputStream extends BaseNCodecInputStream {
      * @param in
      *            InputStream to wrap.
      */
-    public Base32InputStream(InputStream in) {
+    public Base32InputStream(final InputStream in) {
         this(in, false);
     }
 
@@ -57,7 +57,7 @@ public Base32InputStream(InputStream in) {
      * @param doEncode
      *            true if we should encode all data read from us, false if we should decode.
      */
-    public Base32InputStream(InputStream in, boolean doEncode) {
+    public Base32InputStream(final InputStream in, final boolean doEncode) {
         super(in, new Base32(false), doEncode);
     }
 
@@ -77,7 +77,7 @@ public Base32InputStream(InputStream in, boolean doEncode) {
      *            If doEncode is true, each line of encoded data will be terminated with this byte sequence (e.g. \r\n).
      *            If lineLength <= 0, the lineSeparator is not used. If doEncode is false lineSeparator is ignored.
      */
-    public Base32InputStream(InputStream in, boolean doEncode, int lineLength, byte[] lineSeparator) {
+    public Base32InputStream(final InputStream in, final boolean doEncode, final int lineLength, final byte[] lineSeparator) {
         super(in, new Base32(lineLength, lineSeparator), doEncode);
     }
 

src/main/java/org/apache/commons/codec/binary/Base32OutputStream.java

@@ -44,7 +44,7 @@ public class Base32OutputStream extends BaseNCodecOutputStream {
      * @param out
      *            OutputStream to wrap.
      */
-    public Base32OutputStream(OutputStream out) {
+    public Base32OutputStream(final OutputStream out) {
         this(out, true);
     }
 
@@ -57,7 +57,7 @@ public Base32OutputStream(OutputStream out) {
      * @param doEncode
      *            true if we should encode all data written to us, false if we should decode.
      */
-    public Base32OutputStream(OutputStream out, boolean doEncode) {
+    public Base32OutputStream(final OutputStream out, final boolean doEncode) {
         super(out, new Base32(false), doEncode);
     }
 
@@ -77,7 +77,7 @@ public Base32OutputStream(OutputStream out, boolean doEncode) {
      *            If doEncode is true, each line of encoded data will be terminated with this byte sequence (e.g. \r\n).
      *            If lineLength <= 0, the lineSeparator is not used. If doEncode is false lineSeparator is ignored.
      */
-    public Base32OutputStream(OutputStream out, boolean doEncode, int lineLength, byte[] lineSeparator) {
+    public Base32OutputStream(final OutputStream out, final boolean doEncode, final int lineLength, final byte[] lineSeparator) {
         super(out, new Base32(lineLength, lineSeparator), doEncode);
     }