Use isEmpty().

Author: garydgregory

src/main/java/org/apache/commons/cli/DefaultParser.java

@@ -360,7 +360,7 @@ private boolean isShortOption(final String token)
             return true;
         }
         // check for several concatenated short options
-        return optName.length() > 0 && options.hasShortOption(String.valueOf(optName.charAt(0)));
+        return !optName.isEmpty() && options.hasShortOption(String.valueOf(optName.charAt(0)));
     }
 
     /**

src/main/java/org/apache/commons/cli/HelpFormatter.java

@@ -553,14 +553,14 @@ public void printHelp(final PrintWriter pw, final int width, final String cmdLin
             printUsage(pw, width, cmdLineSyntax);
         }
 
-        if (header != null && header.trim().length() > 0)
+        if (header != null && !header.trim().isEmpty())
         {
             printWrapped(pw, width, header);
         }
 
         printOptions(pw, width, options, leftPad, descPad);
 
-        if (footer != null && footer.trim().length() > 0)
+        if (footer != null && !footer.trim().isEmpty())
         {
             printWrapped(pw, width, footer);
         }

src/main/java/org/apache/commons/cli/Option.java

@@ -356,7 +356,7 @@ public String getArgName()
      */
     public boolean hasArgName()
     {
-        return argName != null && argName.length() > 0;
+        return argName != null && !argName.isEmpty();
     }
 
     /**