Skip to content

Dropdown for timepicker (enhancement) #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrnatavio opened this issue Apr 24, 2012 · 6 comments
Open

Dropdown for timepicker (enhancement) #361

rrnatavio opened this issue Apr 24, 2012 · 6 comments

Comments

@rrnatavio
Copy link

My current project required me to change the time sliders into dropdown boxes so I made some changes in the script to change the time sliders for hr/min/sec/ms into dropdown box using tags. I kept the original code intact as much as I can. At this moment I modified it so it may be used by: jQuery(element).datetimepicker({useTimeDropdown: true}) ; The timepicker-addon script have helped a lot in my project so I'd like to return the favor and make my modifications available to the public. Someone out there might have similar needs as mine :) I understand that it needs to be validated/tested/approved first before it may be released. Please inform me if my modifications are interesting. Thanks.

@JKirchartz
Copy link

Hey, rrnatavio, I was just getting started working on doing the same mod. I'd very much appreciate if you'd share your code. Thanks!

@rrnatavio
Copy link
Author

Hey JKirchartz. I'll be pushing my mod by tomorrow. By the way I'm new to git and still familiarizing myself so please bear with me. And thanks for showing interest. I hope it will help you with your needs.

@rrnatavio
Copy link
Author

I have just pushed the mod to 'master'. Usage example:

$('#datetimepicker').datetimepicker({
useTimeDropdown: true
});

Do I need to push this to the 'dev' branch too? If so, how do I fork the branch? Please guide me. I'm still starting to familiarize myself with git. I hope I'm not creating a mess here.

@VILQ
Copy link

VILQ commented May 16, 2012

It seems that I am not alone with those sliders ... Is there any chance that you could share your code ? :)

@rrnatavio
Copy link
Author

Hi VILQ. I have pushed the changes in my repo:

https://github.com/rrnatavio/jQuery-Timepicker-Addon
https://github.com/rrnatavio/jQuery-Timepicker-Addon/blob/master/jquery-ui-timepicker-addon.js

I hope this can help you with your needs.

Unfortunately, I haven't pushed it to trentrichardon's master repo as he requested. I'm having problems setting it up. Can you help me with this?

@rrnatavio rrnatavio reopened this May 17, 2012
@trentrichardson
Copy link
Owner

rrnatavio, I must have missed this topic. I have made some changes since this issue was last active, but if you would like to merge your changes with the dev branch it sounds like a needed and requested feature. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants