Skip to content

Commit 9ab23dc

Browse files
committed
Dialog: Update classes option to use empty string instead of null
1 parent c31c9f1 commit 9ab23dc

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

tests/unit/dialog/dialog_common.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ TestHelpers.commonWidgetTests( "dialog", {
55
buttons: [],
66
classes: {
77
"ui-dialog": "ui-corner-all",
8-
"ui-dialog-content": null,
8+
"ui-dialog-content": "",
99
"ui-dialog-titlebar": "ui-corner-all",
10-
"ui-dialog-titlebar-close": null,
11-
"ui-dialog-title": null,
12-
"ui-dialog-buttons": null,
13-
"ui-dialog-buttonpane": null,
14-
"ui-dialog-buttonset": null,
15-
"ui-dialog-dragging": null,
16-
"ui-dialog-resizing": null,
17-
"ui-widget-overlay": null
10+
"ui-dialog-titlebar-close": "",
11+
"ui-dialog-title": "",
12+
"ui-dialog-buttons": "",
13+
"ui-dialog-buttonpane": "",
14+
"ui-dialog-buttonset": "",
15+
"ui-dialog-dragging": "",
16+
"ui-dialog-resizing": "",
17+
"ui-widget-overlay": ""
1818
},
1919
closeOnEscape: true,
2020
closeText: "Close",

tests/unit/dialog/dialog_common_deprecated.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ TestHelpers.commonWidgetTests( "dialog", {
55
buttons: [],
66
classes: {
77
"ui-dialog": "ui-corner-all",
8-
"ui-dialog-content": null,
8+
"ui-dialog-content": "",
99
"ui-dialog-titlebar": "ui-corner-all",
10-
"ui-dialog-titlebar-close": null,
11-
"ui-dialog-title": null,
12-
"ui-dialog-buttons": null,
13-
"ui-dialog-buttonpane": null,
14-
"ui-dialog-buttonset": null,
15-
"ui-dialog-dragging": null,
16-
"ui-dialog-resizing": null,
17-
"ui-widget-overlay": null
10+
"ui-dialog-titlebar-close": "",
11+
"ui-dialog-title": "",
12+
"ui-dialog-buttons": "",
13+
"ui-dialog-buttonpane": "",
14+
"ui-dialog-buttonset": "",
15+
"ui-dialog-dragging": "",
16+
"ui-dialog-resizing": "",
17+
"ui-widget-overlay": ""
1818
},
1919
closeOnEscape: true,
2020
closeText: "close",

ui/dialog.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@ $.widget( "ui.dialog", {
3737
buttons: [],
3838
classes: {
3939
"ui-dialog": "ui-corner-all",
40-
"ui-dialog-content": null,
40+
"ui-dialog-content": "",
4141
"ui-dialog-titlebar": "ui-corner-all",
42-
"ui-dialog-titlebar-close": null,
43-
"ui-dialog-title": null,
44-
"ui-dialog-buttons": null,
45-
"ui-dialog-buttonpane": null,
46-
"ui-dialog-buttonset": null,
47-
"ui-dialog-dragging": null,
48-
"ui-dialog-resizing": null,
49-
"ui-widget-overlay": null
42+
"ui-dialog-titlebar-close": "",
43+
"ui-dialog-title": "",
44+
"ui-dialog-buttons": "",
45+
"ui-dialog-buttonpane": "",
46+
"ui-dialog-buttonset": "",
47+
"ui-dialog-dragging": "",
48+
"ui-dialog-resizing": "",
49+
"ui-widget-overlay": ""
5050
},
5151
closeOnEscape: true,
5252
closeText: "Close",

0 commit comments

Comments
 (0)