Skip to content

Commit 246dbad

Browse files
author
bra1n
committed
better handling of zero border width case
1 parent 13c90a6 commit 246dbad

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

public/js/lib/models/arrow.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ if (!('CSSArrowPlease' in window)) window.CSSArrowPlease = {};
9696
css += '\tposition: absolute;\n';
9797
css += '\tpointer-events: none;\n';
9898

99-
css += '}\n';
99+
if(hasBorder) css += '}\n';
100100

101101
return css;
102102
},
@@ -111,14 +111,15 @@ if (!('CSSArrowPlease' in window)) window.CSSArrowPlease = {};
111111
@protected
112112
**/
113113
_arrowCSS: function (color, size, layer) {
114-
var pos = this.get('position'),
115-
iPos = this.invertedPosition(),
116-
rgbColor = this.hexToRGB(color),
117-
css = ".arrow_box:";
114+
var pos = this.get('position'),
115+
iPos = this.invertedPosition(),
116+
rgbColor = this.hexToRGB(color),
117+
borderWidth = this.get('borderWidth'),
118+
css = "";
118119

119120
layer = layer || 'after';
120121

121-
css += layer + ' {\n';
122+
if(borderWidth > 0) css += '.arrow_box:' + layer + ' {\n';
122123

123124
css += '\tborder-color: rgba(' + rgbColor.join(', ') + ', 0);\n';
124125
css += '\tborder-' + iPos + '-color: ' + color + ';\n';
@@ -184,7 +185,7 @@ if (!('CSSArrowPlease' in window)) window.CSSArrowPlease = {};
184185
this._arrowBorderCSS()
185186
];
186187

187-
return css.join('\n');
188+
return css.join(css[2] ? '\n':'');
188189
},
189190

190191
/**

0 commit comments

Comments
 (0)