Support all types of Dart ints in the setInt method for SharedPrefs (flutter#64)

Author: mehmetf

packages/shared_preferences/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.2.1] - 2017-05-17
+
+* Support arbitrary length integers for setInt.
+
 ## [0.2.0+1] - 2017-05-16
 
 * Updated README

packages/shared_preferences/android/src/main/java/io/flutter/plugins/shared_preferences/SharedPreferencesPlugin.java

@@ -10,6 +10,7 @@
 import io.flutter.plugin.common.MethodChannel;
 import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
 import io.flutter.plugin.common.PluginRegistry;
+import java.math.BigInteger;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -20,6 +21,8 @@ public class SharedPreferencesPlugin implements MethodCallHandler {
   private static final String SHARED_PREFERENCES_NAME = "FlutterSharedPreferences";
   private static final String CHANNEL_NAME = "plugins.flutter.io/shared_preferences";
 
+  private static final String BIG_INTEGER_PREFIX = "VGhpcyBpcyB0aGUgcHJlZml4IGZvciBCaWdJbnRlZ2Vy";
+
   private final android.content.SharedPreferences preferences;
   private final android.content.SharedPreferences.Editor editor;
 
@@ -40,7 +43,15 @@ private Map<String, Object> getAllPrefs() {
     Map<String, Object> filteredPrefs = new HashMap<>();
     for (String key : allPrefs.keySet()) {
       if (key.startsWith("flutter.")) {
-        filteredPrefs.put(key, allPrefs.get(key));
+        Object value = allPrefs.get(key);
+        if (value instanceof String) {
+          String stringValue = (String) value;
+          if (stringValue.startsWith(BIG_INTEGER_PREFIX)) {
+            String encoded = stringValue.substring(BIG_INTEGER_PREFIX.length());
+            value = new BigInteger(encoded, Character.MAX_RADIX);
+          }
+        }
+        filteredPrefs.put(key, value);
       }
     }
     return filteredPrefs;
@@ -59,7 +70,14 @@ public void onMethodCall(MethodCall call, MethodChannel.Result result) {
         result.success(null);
         break;
       case "setInt":
-        editor.putInt(key, (int) call.argument("value")).apply();
+        Number value = call.argument("value");
+        if (value instanceof BigInteger) {
+          BigInteger integerValue = (BigInteger) value;
+          editor.putString(key, BIG_INTEGER_PREFIX + integerValue.toString(Character.MAX_RADIX));
+        } else {
+          editor.putLong(key, value.longValue());
+        }
+        editor.apply();
         result.success(null);
         break;
       case "setString":

packages/shared_preferences/ios/Classes/SharedPreferencesPlugin.m

@@ -25,7 +25,10 @@ + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
     } else if ([method isEqualToString:@"setInt"]) {
       NSString *key = arguments[@"key"];
       NSNumber *value = arguments[@"value"];
-      [[NSUserDefaults standardUserDefaults] setInteger:value.intValue forKey:key];
+      // int type in Dart can come to native side in a variety of forms
+      // It is best to store it as is and send it back when needed.
+      // Platform channel will handle the conversion.
+      [[NSUserDefaults standardUserDefaults] setValue:value forKey:key];
       result(nil);
     } else if ([method isEqualToString:@"setDouble"]) {
       NSString *key = arguments[@"key"];

packages/shared_preferences/pubspec.yaml

@@ -1,6 +1,6 @@
 name: shared_preferences
 
-version: 0.2.0+1
+version: 0.2.1
 description: A Flutter plugin for reading and writing simple key-value pairs.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences