fixed issue commons-app#3110 and commons-app#3112

Author: vanshikaarora

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -342,6 +342,7 @@ private void setTextFields(Media media) {
      */
 
     private void rebuildDepictionList() {
+        depictionContainer.removeAllViews();
         for (int i = 0; i<depictions.size(); i++) {
             String depictionName = depictions.get(i).get("label");
             String depictionUrl = depictions.get(i).get("url");

app/src/main/res/layout/fragment_media_detail.xml

@@ -109,30 +109,6 @@
                         tools:text="Title of the media" />
                 </LinearLayout>
 
-                <LinearLayout
-                    android:id="@+id/depicts_layout"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:background="?attr/subBackground"
-                    android:orientation="vertical"
-                    android:padding="@dimen/standard_gap">
-
-                    <TextView
-                        android:layout_width="match_parent"
-                        android:layout_height="wrap_content"
-                        android:paddingBottom="@dimen/tiny_gap"
-                        android:text="@string/media_detail_depiction"
-                        android:textColor="@android:color/white"
-                        android:textSize="@dimen/normal_text"
-                        android:textStyle="bold" />
-
-                    <LinearLayout
-                        android:id="@+id/media_detail_depiction_container"
-                        android:layout_width="match_parent"
-                        android:layout_height="wrap_content"
-                        android:orientation="vertical" />
-                </LinearLayout>
-
                 <fr.free.nrw.commons.media.MediaDetailSpacer
                     android:layout_width="match_parent"
                     android:layout_height="@dimen/small_gap" />
@@ -274,6 +250,30 @@
                     android:layout_width="match_parent"
                     android:layout_height="@dimen/small_gap" />
 
+                <LinearLayout
+                    android:id="@+id/depicts_layout"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:background="?attr/subBackground"
+                    android:orientation="vertical"
+                    android:padding="@dimen/standard_gap">
+
+                    <TextView
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:paddingBottom="@dimen/tiny_gap"
+                        android:text="@string/media_detail_depiction"
+                        android:textColor="@android:color/white"
+                        android:textSize="@dimen/normal_text"
+                        android:textStyle="bold" />
+
+                    <LinearLayout
+                        android:id="@+id/media_detail_depiction_container"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        android:orientation="vertical" />
+                </LinearLayout>
+
                 <LinearLayout
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"