Optimize widget's _createWidget method to not store data and bind remove

jzaefferer · jzaefferer · commit 03dcdd637329 · 2011-01-31T16:33:45.000+01:00
when dealing with an instance without an element (element == instance).
diff --git a/ui/jquery.ui.widget.js b/ui/jquery.ui.widget.js
@@ -134,18 +134,19 @@ $.Widget.prototype = {
 	},
 	_createWidget: function( options, element ) {
 		element = $( element || this.defaultElement || this )[ 0 ];
-		$.data( element, this.widgetName, this );
 		this.element = $( element );
 		this.options = $.extend( true, {},
 			this.options,
 			this._getCreateOptions(),
 			options );
-
-		var self = this;
-		this.element.bind( "remove." + this.widgetName, function() {
-			self.destroy();
-		});
-
+		if (element !== this) {
+			$.data(element, this.widgetName, this);
+			
+			var self = this;
+			this.element.bind("remove." + this.widgetName, function(){
+				self.destroy();
+			});
+		}
 		this._create();
 		this._trigger( "create" );
 		this._init();
