Fix for white-space nodes in FF and Chrome.

BorisMoore · BorisMoore · commit 32bffb53346f · 2011-03-16T12:55:39.000-07:00
diff --git a/beta2/3collectionChange.html b/beta2/3collectionChange.html
@@ -15,7 +15,7 @@
 <body>
 	<button onclick="showData()">show data</button>
 
-	<button onclick="setName()">set name</button>
+	<button onclick="setLastName()">set last name</button>
 	<button onclick="append()">append</button>
 	<button onclick="deleteLast()">delete last row</button>
 	<hr /><br />
@@ -104,8 +104,10 @@
 
 			});
 
-		function setName() {
-			$.setField( people[0], "lastName", "Greenford" );
+		function setLastName() {
+			if ( people.length ) {
+				$.setField( people[ people.length - 1 ], "lastName", "NewLastName" );
+			}
 		}
 
 		function append() {
diff --git a/beta2/4tmplRender.html b/beta2/4tmplRender.html
@@ -15,7 +15,7 @@
 <body>
 	<button onclick="showData()">show data</button>
 
-	<button onclick="setName()">set name</button>
+	<button onclick="setLastName()">set last name</button>
 	<button onclick="append()">append</button>
 	<button onclick="deleteLast()">delete last row</button>
 	<hr /><br />
@@ -80,8 +80,10 @@ <h3>Read-only</h3>
 
 			});
 
-		function setName() {
-			$.setField( people[0], "lastName", "Greenford" );
+		function setLastName() {
+			if ( people.length ) {
+				$.setField( people[ people.length - 1 ], "lastName", "NewLastName" );
+			}
 		}
 
 		function append() {
diff --git a/beta2/jquery.datalink2.js b/beta2/jquery.datalink2.js
@@ -477,7 +477,8 @@ function setViewItems( root, object ) {
 	}
 
 	function processElem( el ) {
-		var path = el.getAttribute( pathAttr ),
+		var node =  el,
+			path = el.getAttribute( pathAttr ),
 			binding = el.getAttribute( bindAttr );
 
 		if ( path ) {
@@ -486,9 +487,12 @@ function setViewItems( root, object ) {
 				addItem( path, getLinkedPath( el.parentNode )[0]);
 			}
 			nodes.push( prevNode = el );
-		} else if ( el.previousSibling === prevNode ) {
-			el.setAttribute( pathAttr, prevPath );
-			nodes.push( prevNode = el );
+		} else {
+			while ( (node = node.previousSibling) && node.nodeType !== 1 ) {} // TODO Later support intermediate text nodes
+			if ( node === prevNode ) {
+				el.setAttribute( pathAttr, prevPath );
+				nodes.push( prevNode = el );
+			}
 		}
 		if ( binding ) {
 			bind.push( el );
diff --git a/beta2/simple-explicit.html b/beta2/simple-explicit.html
@@ -69,7 +69,7 @@ <h3>Declarative</h3>
 			});
 			$(person).trigger("refresh");
 		});
-		
+
 		$(person).bind("refresh", function() {
 			$(".roleColor").css({
 				backgroundColor: person.roleColor
