From 067c2e8a796de9da1ad4aa9babe85bb3f806992a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Thu, 21 Feb 2019 05:05:55 +0100 Subject: [PATCH 1/3] [css-layout-api] Name the FragmentResultOptions argument (#858) This was invalid Web IDL. Also make it optional since there are no required members. --- css-layout-api/Overview.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/css-layout-api/Overview.bs b/css-layout-api/Overview.bs index 899f1cee..4ff3b7c5 100644 --- a/css-layout-api/Overview.bs +++ b/css-layout-api/Overview.bs @@ -1594,7 +1594,7 @@ dictionary FragmentResultOptions { BreakTokenOptions breakToken = null; }; -[Constructor(FragmentResultOptions)] +[Constructor(optional FragmentResultOptions options)] interface FragmentResult { readonly attribute double inlineSize; readonly attribute double blockSize; From 5357e788752433330787c02ea81818de2d5dbb12 Mon Sep 17 00:00:00 2001 From: Tab Atkins-Bittner Date: Thu, 21 Feb 2019 11:31:20 -0800 Subject: [PATCH 2/3] [css-properties-values-api] Fix all linking errors. --- css-properties-values-api/Overview.bs | 63 +++++++++++++-------------- 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a/css-properties-values-api/Overview.bs b/css-properties-values-api/Overview.bs index 8459616e..444ae71d 100644 --- a/css-properties-values-api/Overview.bs +++ b/css-properties-values-api/Overview.bs @@ -25,22 +25,21 @@ Ignored Terms: WorkletGlobalContext Repository: w3c/css-houdini-drafts -
-{
-	"css-paint-api": {
-		"title": "CSS Painting API"
-	},
-	"css-layout-api": {
-		"title": "CSS Layout API"
-	}
-}
-
- 
+spec:css-color-4; type:property; text:color
+spec:css-syntax-3; type:dfn;
+	text:input stream
+	text:starts with an identifier
+	text:consume a name
 spec:css-transforms-1; type:type; text:
+spec:css-values-4; type:value;
+	text:ex
+	text:cap
 spec:cssom-1; type:interface; text:CSS
-spec:css-color-4; type:property; text:color
 spec:dom; type:interface; text:Document
+spec:infra; type:dfn;
+	text:string
+	text:list
Introduction {#intro} @@ -58,7 +57,7 @@ of other properties via a var() reference. This specification extends [[css-variables]], allowing the registration of properties that have a value type, an initial value, and a defined inheritance behaviour. -This specification is complementary to [[css-paint-api]] and [[css-layout-api]], which +This specification is complementary to [[css-paint-api-1]] and [[css-layout-api-1]], which allow custom properties to directly impact paint and layout behaviours respectively. Registering custom properties {#registering-custom-properties} @@ -83,7 +82,7 @@ which is a set of records that describe registered custom properties. The {{PropertyDescriptor}} dictionary {#the-propertydescriptor-dictionary} -------------------------------------------------------------------------- -A PropertyDescriptor dictionary represents author-specified configuration +A PropertyDescriptor dictionary represents author-specified configuration options for a custom property. {{PropertyDescriptor}} dictionaries contain the following members: @@ -346,8 +345,8 @@ but be automatically [=invalid at computed-value time=]. As ''@supports'' tests parse behavior, it thus also accepts all values as valid regardless of the registered syntax. -Dependency cycles via relative units ------------------------------------- +Dependency cycles via relative units {#dependency-cycles} +--------------------------------------------------------- Registered custom properties follow the same rules for dependency cycle resolution as unregistered custom properties, with the following additional @@ -366,7 +365,7 @@ component: * If the property contains any of the following units: ''rem'', ''rlh''; then add an edge between the property and the 'font-size'' of the root element. -* If the property contains the 'rlh' unit, add an edge between the property +* If the property contains the ''rlh'' unit, add an edge between the property and the 'line-height'' of the root element.
@@ -446,7 +445,7 @@ strings. Supported names {#supported-names} ---------------------------------- -This section defines the supported syntax component names, and the +This section defines the supported syntax component names, and the corresponding types accepted by the resulting syntax component. : "<length>" @@ -587,26 +586,26 @@ Parsing the syntax string {#parsing-syntax} preprocessed as specified in [[css-syntax-3]]. Let |descriptor| be an initially empty [=list=] of syntax components. - 5. Repeatedly consume the next input code point: + 5. Repeatedly consume the next input code point from |stream|: : whitespace :: Do nothing. : EOF - :: If |descriptor|’s [=list/length=] is greater than zero, + :: If |descriptor|’s [=list/size=] is greater than zero, return |descriptor|; otherwise, return failure. : U+007C VERTICAL LINE (|) - :: Consume a syntax component. + :: Consume a syntax component from |stream|. If failure was returned, return failure; otherwise, [=list/append=] the returned value to |descriptor|. : anything else - :: Reconsume the current input code point. - Consume a syntax component. + :: Reconsume the current input code point in |stream|. + Consume a syntax component from |stream|. If failure was returned, return failure; otherwise, @@ -623,18 +622,18 @@ Parsing the syntax string {#parsing-syntax} Let |component| be a new syntax component with its |name| and |multiplier| initially empty. - Consume the next input code point: + Consume the next input code point |stream|: : U+003C LESS-THAN SIGN (<) - :: Consume a data type name. + :: Consume a data type name from |stream|. If it returned a [=string=], set |component|'s |name| to the returned value. Otherwise, return failure. : name-start code point : U+005C REVERSE SOLIDUS (\) :: If the stream [=starts with an identifier=], - reconsume the current input code point - then [=consume a name=] from the stream, + reconsume the current input code point from |stream| + then [=consume a name=] from |stream|, and set |component|’s |name| to the returned <>’s value. Otherwise return failure. @@ -644,14 +643,13 @@ Parsing the syntax string {#parsing-syntax} If |component|’s |name| is a [=pre-multiplied data type name=], return |component|. - If the [=next input code point=] + If the [=next input code point=] in |stream| is U+002B PLUS SIGN (+) or U+0023 NUMBER SIGN (#), - consume the next input code point, + consume the next input code point from |stream|, and set |component|’s |multiplier| to the [=current input code point=]. Return |component|. -
### Consume a data type name ### {#consume-data-type-name} @@ -666,8 +664,9 @@ Parsing the syntax string {#parsing-syntax} Repeatedly consume the next input code point: : U+003E GREATER-THAN SIGN (>) - :: Append the code point to |name|. If |name| matches one of the - data type names listed in [[#supported-names]], return |name|. + :: Append the code point to |name|. + If |name| is a [=supported syntax component name=], + return |name|. Otherwise return failure. : name code point From 648988a4a1efe3b450ad2626738416848fe1ca73 Mon Sep 17 00:00:00 2001 From: Anders Hartvoll Ruud Date: Mon, 18 Feb 2019 09:24:46 +0100 Subject: [PATCH 3/3] [css-properties-values-api] "Consume a name" returns a string. "Consume a name" doesn't return an . Also, it seems more clean to avoid tokens completely (if possible). --- css-properties-values-api/Overview.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/css-properties-values-api/Overview.bs b/css-properties-values-api/Overview.bs index 444ae71d..a7928f2e 100644 --- a/css-properties-values-api/Overview.bs +++ b/css-properties-values-api/Overview.bs @@ -634,7 +634,7 @@ Parsing the syntax string {#parsing-syntax} :: If the stream [=starts with an identifier=], reconsume the current input code point from |stream| then [=consume a name=] from |stream|, - and set |component|’s |name| to the returned <>’s value. + and set |component|’s |name| to the returned value. Otherwise return failure. : anything else