Skip to content

[CSS Typed OM] CSSFontFaceValue objects can't store source value #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nainar opened this issue Sep 12, 2016 · 6 comments
Closed

[CSS Typed OM] CSSFontFaceValue objects can't store source value #293

nainar opened this issue Sep 12, 2016 · 6 comments

Comments

@nainar
Copy link
Contributor

nainar commented Sep 12, 2016

In the case of CSSFontFaceValue objects, shouldn't the have a member that stores the source as well?

For eg in the case:

@font-face {
font-family: "XYZ";
src: url("https://mdn.mozillademos.org/files/2468/VeraSeBd.ttf");
}

I am assuming the specified member fontFaceName stores the string "XYZ" and we will need to store the source in another member.Potentially in a CSSFontFaceSrcValue which inherits from CSSFontFaceValue? This can deal with the case where it is specified as a url or as a local value

@nainar
Copy link
Contributor Author

nainar commented Sep 12, 2016

@shans

@nainar nainar changed the title [CSS Typed OM] [CSS Typed OM] CSSFontFaceValue objects can't store source value Sep 12, 2016
@shans
Copy link
Contributor

shans commented Apr 3, 2017

@tabatkins @bfgeek how important is this for L1?

@tabatkins
Copy link
Member

Why can't we just expose the string?

@shans
Copy link
Contributor

shans commented Apr 4, 2017

that would be fine. But do we need it for L1?

@tabatkins
Copy link
Member

I mean, do we need any of the descriptors from @font-face? It seems weird to only offer some of them.

@shans
Copy link
Contributor

shans commented May 23, 2017

We're going to track this stuff in #405. The whole design of CSSFontFaceValue needs to be reconsidered.

@shans shans closed this as completed May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants