-
Notifications
You must be signed in to change notification settings - Fork 142
[css-paint-api] IDL for PaintWorkletGlobalScope is invalid #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As far as I can tell and based on the follow up discussion in #907 the current PaintWorklet definition is correct. [Exposed=Worklet]
interface WorkletGlobalScope {};
[Global=(Worklet,PaintWorklet),Exposed=PaintWorklet]
interface PaintWorkletGlobalScope : WorkletGlobalScope {} This is because "Global" affects exposure sets which is what happens is these particular cases. See @tabatkins comment for more detail You may want to adjust the idlharness test to make sure it does take this into account. |
I think my confusion lies in the way that @tabatkins Should we be doing the same thing with |
Yes, it looks like this is a problem in the harness, where it's not using sufficient global knowledge to understand that PaintWorklet is a subset of Worklet. The current structure of the (A better structure would probably be to have a more explicit "subclassing" of global names, so that you could declare, say, |
Related to #907
web-platform-tests/wpt#17551 introduces a test to catch this case, which causes
/css/css-paint-api/idlharness.html
in WPT to regress, e.g.https://wpt.fyi/results/css/css-paint-api/idlharness.html?diff&filter=ADC&run_id=251400002&run_id=261060002
The text was updated successfully, but these errors were encountered: