Skip to content

Commit 1832f1b

Browse files
zcorpansvgeesus
authored andcommitted
WebKitCSSMatrix compat: optional arguments
Make all arguments optional for DOMMatrix/DOMMatrixReadOnly methods, except for setMatrixValue() which throws in WebKit anyway (because "undefined" fails to parse). I made everything optional to be consistent; making the minimal set of arguments optional would be self-inconsistent and confusing (e.g. skewX vs. skewXSelf). Part of whatwg/compat#19
1 parent 188b6af commit 1832f1b

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

geometry/Overview.bs

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -438,30 +438,30 @@ interface DOMMatrixReadOnly {
438438
readonly attribute boolean isIdentity;
439439

440440
// Immutable transform methods
441-
DOMMatrix translate(unrestricted double tx,
442-
unrestricted double ty,
441+
DOMMatrix translate(optional unrestricted double tx = 0,
442+
optional unrestricted double ty = 0,
443443
optional unrestricted double tz = 0);
444444
DOMMatrix scale(optional unrestricted double scaleX = 1,
445445
optional unrestricted double scaleY,
446446
optional unrestricted double scaleZ = 1,
447447
optional unrestricted double originX = 0,
448448
optional unrestricted double originY = 0,
449449
optional unrestricted double originZ = 0);
450-
DOMMatrix scale3d(unrestricted double scale,
450+
DOMMatrix scale3d(optional unrestricted double scale = 1,
451451
optional unrestricted double originX = 0,
452452
optional unrestricted double originY = 0,
453453
optional unrestricted double originZ = 0);
454454
DOMMatrix rotate(optional unrestricted double rotX = 0,
455455
optional unrestricted double rotY,
456456
optional unrestricted double rotZ);
457-
DOMMatrix rotateFromVector(unrestricted double x,
458-
unrestricted double y);
459-
DOMMatrix rotateAxisAngle(unrestricted double x,
460-
unrestricted double y,
461-
unrestricted double z,
462-
unrestricted double angle);
463-
DOMMatrix skewX(unrestricted double sx);
464-
DOMMatrix skewY(unrestricted double sy);
457+
DOMMatrix rotateFromVector(optional unrestricted double x = 0,
458+
optional unrestricted double y = 0);
459+
DOMMatrix rotateAxisAngle(optional unrestricted double x = 0,
460+
optional unrestricted double y = 0,
461+
optional unrestricted double z = 0,
462+
optional unrestricted double angle = 0);
463+
DOMMatrix skewX(optional unrestricted double sx = 0);
464+
DOMMatrix skewY(optional unrestricted double sy = 0);
465465
DOMMatrix multiply(optional DOMMatrixInit other);
466466
DOMMatrix flipX();
467467
DOMMatrix flipY();
@@ -510,30 +510,30 @@ interface DOMMatrix : DOMMatrixReadOnly {
510510
// Mutable transform methods
511511
DOMMatrix multiplySelf(optional DOMMatrixInit other);
512512
DOMMatrix preMultiplySelf(optional DOMMatrixInit other);
513-
DOMMatrix translateSelf(unrestricted double tx,
514-
unrestricted double ty,
515-
optional unrestricted double tz = 0);
513+
DOMMatrix translateSelf(optional unrestricted double tx = 0,
514+
optional unrestricted double ty = 0,
515+
optional unrestricted double tz = 0);
516516
DOMMatrix scaleSelf(optional unrestricted double scaleX = 1,
517517
optional unrestricted double scaleY,
518518
optional unrestricted double scaleZ = 1,
519519
optional unrestricted double originX = 0,
520520
optional unrestricted double originY = 0,
521521
optional unrestricted double originZ = 0);
522-
DOMMatrix scale3dSelf(unrestricted double scale,
523-
optional unrestricted double originX = 0,
524-
optional unrestricted double originY = 0,
525-
optional unrestricted double originZ = 0);
522+
DOMMatrix scale3dSelf(optional unrestricted double scale = 1,
523+
optional unrestricted double originX = 0,
524+
optional unrestricted double originY = 0,
525+
optional unrestricted double originZ = 0);
526526
DOMMatrix rotateSelf(optional unrestricted double rotX = 0,
527527
optional unrestricted double rotY,
528528
optional unrestricted double rotZ);
529-
DOMMatrix rotateFromVectorSelf(unrestricted double x,
530-
unrestricted double y);
531-
DOMMatrix rotateAxisAngleSelf(unrestricted double x,
532-
unrestricted double y,
533-
unrestricted double z,
534-
unrestricted double angle);
535-
DOMMatrix skewXSelf(unrestricted double sx);
536-
DOMMatrix skewYSelf(unrestricted double sy);
529+
DOMMatrix rotateFromVectorSelf(optional unrestricted double x = 0,
530+
optional unrestricted double y = 0);
531+
DOMMatrix rotateAxisAngleSelf(optional unrestricted double x = 0,
532+
optional unrestricted double y = 0,
533+
optional unrestricted double z = 0,
534+
optional unrestricted double angle = 0);
535+
DOMMatrix skewXSelf(optional unrestricted double sx = 0);
536+
DOMMatrix skewYSelf(optional unrestricted double sy = 0);
537537
DOMMatrix invertSelf();
538538

539539
DOMMatrix setMatrixValue(DOMString transformList);

0 commit comments

Comments
 (0)