Skip to content

Commit 1c20386

Browse files
frivoalfrivoal
committed
[css-contain] Editorial tweak in introduction
Closes #4466
1 parent bc14435 commit 1c20386

6 files changed

Lines changed: 170 additions & 2 deletions

File tree

‎css-contain-1/Overview.bs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ Introduction</h2>
4848

4949
There are various heuristics that can be used to guess when a given sub-tree is independent of the rest of the page in some manner,
5050
but they're fragile,
51-
so innocuous changes to a page may inadvertently make it flunk the heuristics and fall into a slow mode.
51+
so innocuous changes to a page may inadvertently make it fail such heuristic tests,
52+
causing rendering to fall into a slow code path.
5253
There are also many things that would be good to isolate which are difficult or impossible to detect in a heuristic manner.
5354

5455
To alleviate these problems

‎css-contain-1/issues-2019-10-pr.html‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
<!DOCTYPE html>
2+
<meta charset="utf-8">
3+
<title>CSS Contain Level 1 Disposition of Comments for 2019-10-15 PR</title>
4+
<style>
5+
.a { background: lightgreen }
6+
.d { background: lightblue }
7+
.r { background: orange }
8+
.fo { background: red }
9+
.open { border: solid red; padding: 0.2em; }
10+
:target { box-shadow: 0.25em 0.25em 0.25em; }
11+
</style>
12+
13+
<h1>CSS Contain Level 1 Disposition of Comments for 2019-10-15 PR</h1>
14+
15+
<p>Review document: <a href="https://www.w3.org/TR/2019/PR-css-contain-1-20191015/">https://www.w3.org/TR/2019/PR-css-contain-1-20191015/</a>
16+
17+
<p>Editor's draft: <a href="http://dev.w3.org/csswg/css-contain-1/">http://dev.w3.org/csswg/css-contain-1/</a>
18+
19+
<p>The following color coding convention is used for comments:</p>
20+
21+
<ul>
22+
<li class="a">Accepted or Rejected and positive response
23+
<li class="r">Rejected and no response
24+
<li class="fo">Rejected and negative response
25+
<li class="d">Deferred
26+
<li class="oi">Out-of-Scope or Invalid and not verified
27+
</ul>
28+
29+
<p class=open>Open issues are marked like this</p>
30+
31+
<p>An issue can be closed as <code>Accepted</code>, <code>OutOfScope</code>,
32+
<code>Invalid</code>, <code>Rejected</code>, or <code>Retracted</code>.
33+
<code>Verified</code> indicates commentor's acceptance of the response.</p>
34+
<pre class='a' id='issue-1'>
35+
Issue 1. <a href='#issue-1'>#</a>
36+
Summary: Suggest Rephrasing in Introduction
37+
From: Chris Needham
38+
Comment: <a href='https://github.com/w3c/csswg-drafts/issues/4466'>https://github.com/w3c/csswg-drafts/issues/4466</a>
39+
Response: <a href='https://github.com/w3c/csswg-drafts/pull/3898'>https://github.com/w3c/csswg-drafts/pull/3898</a>
40+
Closed: Accepted
41+
Resolved: Editorial</pre>
42+
<script>
43+
(function () {
44+
var sheet = document.styleSheets[0];
45+
function addCheckbox(className) {
46+
var element = document.querySelector('*.' + className);
47+
var label = document.createElement('label');
48+
label.innerHTML = element.innerHTML;
49+
element.innerHTML = null;
50+
var check = document.createElement('input');
51+
check.type = 'checkbox';
52+
if (className == 'open') {
53+
check.checked = false;
54+
sheet.insertRule('pre:not(.open)' + '{}', sheet.cssRules.length);
55+
check.onchange = function (e) {
56+
rule.style.display = this.checked ? 'none' : 'block';
57+
}
58+
}
59+
else {
60+
check.checked = true;
61+
sheet.insertRule('pre.' + className + '{}', sheet.cssRules.length);
62+
check.onchange = function (e) {
63+
rule.style.display = this.checked ? 'block' : 'none';
64+
}
65+
}
66+
var rule = sheet.cssRules[sheet.cssRules.length - 1];
67+
element.appendChild(label);
68+
label.insertBefore(check, label.firstChild);
69+
}
70+
['a', 'd', 'fo', 'oi', 'r', 'open'].forEach(addCheckbox);
71+
}());
72+
</script>

‎css-contain-1/issues-2019-10-pr.txt‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
Draft: https://www.w3.org/TR/2019/PR-css-contain-1-20191015/
2+
Title: CSS Contain Level 1
3+
4+
----
5+
Issue 1.
6+
Summary: Suggest Rephrasing in Introduction
7+
From: Chris Needham
8+
Comment: https://github.com/w3c/csswg-drafts/issues/4466
9+
Response: https://github.com/w3c/csswg-drafts/pull/3898
10+
Closed: Accepted
11+
Resolved: Editorial

‎css-contain-2/Overview.bs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ Introduction</h2>
5050

5151
There are various heuristics that can be used to guess when a given sub-tree is independent of the rest of the page in some manner,
5252
but they're fragile,
53-
so innocuous changes to a page may inadvertently make it flunk the heuristics and fall into a slow mode.
53+
so innocuous changes to a page may inadvertently make it fail such heuristic tests,
54+
causing rendering to fall into a slow code path.
5455
There are also many things that would be good to isolate which are difficult or impossible to detect in a heuristic manner.
5556

5657
To alleviate these problems

‎css-contain-2/issues-2019-10-pr.html‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
<!DOCTYPE html>
2+
<meta charset="utf-8">
3+
<title>CSS Contain Level 2 Disposition of Comments for 2019-10-15 WD</title>
4+
<style>
5+
.a { background: lightgreen }
6+
.d { background: lightblue }
7+
.r { background: orange }
8+
.fo { background: red }
9+
.open { border: solid red; padding: 0.2em; }
10+
:target { box-shadow: 0.25em 0.25em 0.25em; }
11+
</style>
12+
13+
<h1>CSS Contain Level 2 Disposition of Comments for 2019-10-15 WD</h1>
14+
15+
<p>Review document: <a href="https://www.w3.org/TR/2019/WD-css-contain-2-20191015/">https://www.w3.org/TR/2019/WD-css-contain-2-20191015/</a>
16+
17+
<p>Editor's draft: <a href="http://dev.w3.org/csswg/css-contain-2/">http://dev.w3.org/csswg/css-contain-2/</a>
18+
19+
<p>The following color coding convention is used for comments:</p>
20+
21+
<ul>
22+
<li class="a">Accepted or Rejected and positive response
23+
<li class="r">Rejected and no response
24+
<li class="fo">Rejected and negative response
25+
<li class="d">Deferred
26+
<li class="oi">Out-of-Scope or Invalid and not verified
27+
</ul>
28+
29+
<p class=open>Open issues are marked like this</p>
30+
31+
<p>An issue can be closed as <code>Accepted</code>, <code>OutOfScope</code>,
32+
<code>Invalid</code>, <code>Rejected</code>, or <code>Retracted</code>.
33+
<code>Verified</code> indicates commentor's acceptance of the response.</p>
34+
<pre class='a' id='issue-1'>
35+
Issue 1. <a href='#issue-1'>#</a>
36+
Summary: Suggest Rephrasing in Introduction
37+
From: Chris Needham
38+
Comment: <a href='https://github.com/w3c/csswg-drafts/issues/4466'>https://github.com/w3c/csswg-drafts/issues/4466</a>
39+
Response: <a href='https://github.com/w3c/csswg-drafts/pull/3898'>https://github.com/w3c/csswg-drafts/pull/3898</a>
40+
Closed: Accepted
41+
Resolved: Editorial</pre>
42+
<script>
43+
(function () {
44+
var sheet = document.styleSheets[0];
45+
function addCheckbox(className) {
46+
var element = document.querySelector('*.' + className);
47+
var label = document.createElement('label');
48+
label.innerHTML = element.innerHTML;
49+
element.innerHTML = null;
50+
var check = document.createElement('input');
51+
check.type = 'checkbox';
52+
if (className == 'open') {
53+
check.checked = false;
54+
sheet.insertRule('pre:not(.open)' + '{}', sheet.cssRules.length);
55+
check.onchange = function (e) {
56+
rule.style.display = this.checked ? 'none' : 'block';
57+
}
58+
}
59+
else {
60+
check.checked = true;
61+
sheet.insertRule('pre.' + className + '{}', sheet.cssRules.length);
62+
check.onchange = function (e) {
63+
rule.style.display = this.checked ? 'block' : 'none';
64+
}
65+
}
66+
var rule = sheet.cssRules[sheet.cssRules.length - 1];
67+
element.appendChild(label);
68+
label.insertBefore(check, label.firstChild);
69+
}
70+
['a', 'd', 'fo', 'oi', 'r', 'open'].forEach(addCheckbox);
71+
}());
72+
</script>

‎css-contain-2/issues-2019-10-pr.txt‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
Draft: https://www.w3.org/TR/2019/WD-css-contain-2-20191015/
2+
Title: CSS Contain Level 2
3+
4+
----
5+
Issue 1.
6+
Summary: Suggest Rephrasing in Introduction
7+
From: Chris Needham
8+
Comment: https://github.com/w3c/csswg-drafts/issues/4466
9+
Response: https://github.com/w3c/csswg-drafts/pull/3898
10+
Closed: Accepted
11+
Resolved: Editorial

0 commit comments

Comments
 (0)