Skip to content

Commit 485bb14

Browse files
zcorpansvgeesus
authored andcommitted
Annotate DOMMatrix's immutable methods with [NewObject]
This should be editorial. It is a bit unclear from the definitions of toFloat32Array() and toFloat64Array() if they could return the same value, but it appears Chromium and Gecko return new values. Tests: web-platform-tests/wpt#5862 Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=29541
1 parent cb687e7 commit 485bb14

File tree

1 file changed

+35
-34
lines changed

1 file changed

+35
-34
lines changed

geometry/Overview.bs

Lines changed: 35 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -491,40 +491,41 @@ interface DOMMatrixReadOnly {
491491
readonly attribute boolean isIdentity;
492492

493493
// Immutable transform methods
494-
DOMMatrix translate(optional unrestricted double tx = 0,
495-
optional unrestricted double ty = 0,
496-
optional unrestricted double tz = 0);
497-
DOMMatrix scale(optional unrestricted double scaleX = 1,
498-
optional unrestricted double scaleY,
499-
optional unrestricted double scaleZ = 1,
500-
optional unrestricted double originX = 0,
501-
optional unrestricted double originY = 0,
502-
optional unrestricted double originZ = 0);
503-
DOMMatrix scale3d(optional unrestricted double scale = 1,
504-
optional unrestricted double originX = 0,
505-
optional unrestricted double originY = 0,
506-
optional unrestricted double originZ = 0);
507-
DOMMatrix rotate(optional unrestricted double rotX = 0,
508-
optional unrestricted double rotY,
509-
optional unrestricted double rotZ);
510-
DOMMatrix rotateFromVector(optional unrestricted double x = 0,
511-
optional unrestricted double y = 0);
512-
DOMMatrix rotateAxisAngle(optional unrestricted double x = 0,
513-
optional unrestricted double y = 0,
514-
optional unrestricted double z = 0,
515-
optional unrestricted double angle = 0);
516-
DOMMatrix skewX(optional unrestricted double sx = 0);
517-
DOMMatrix skewY(optional unrestricted double sy = 0);
518-
DOMMatrix multiply(optional DOMMatrixInit other);
519-
DOMMatrix flipX();
520-
DOMMatrix flipY();
521-
DOMMatrix inverse();
522-
523-
DOMPoint transformPoint(optional DOMPointInit point);
524-
Float32Array toFloat32Array();
525-
Float64Array toFloat64Array();
526-
stringifier;
527-
serializer = { attribute };
494+
[NewObject] DOMMatrix translate(optional unrestricted double tx = 0,
495+
optional unrestricted double ty = 0,
496+
optional unrestricted double tz = 0);
497+
[NewObject] DOMMatrix scale(optional unrestricted double scaleX = 1,
498+
optional unrestricted double scaleY,
499+
optional unrestricted double scaleZ = 1,
500+
optional unrestricted double originX = 0,
501+
optional unrestricted double originY = 0,
502+
optional unrestricted double originZ = 0);
503+
[NewObject] DOMMatrix scale3d(optional unrestricted double scale = 1,
504+
optional unrestricted double originX = 0,
505+
optional unrestricted double originY = 0,
506+
optional unrestricted double originZ = 0);
507+
[NewObject] DOMMatrix rotate(optional unrestricted double rotX = 0,
508+
optional unrestricted double rotY,
509+
optional unrestricted double rotZ);
510+
[NewObject] DOMMatrix rotateFromVector(optional unrestricted double x = 0,
511+
optional unrestricted double y = 0);
512+
[NewObject] DOMMatrix rotateAxisAngle(optional unrestricted double x = 0,
513+
optional unrestricted double y = 0,
514+
optional unrestricted double z = 0,
515+
optional unrestricted double angle = 0);
516+
[NewObject] DOMMatrix skewX(optional unrestricted double sx = 0);
517+
[NewObject] DOMMatrix skewY(optional unrestricted double sy = 0);
518+
[NewObject] DOMMatrix multiply(optional DOMMatrixInit other);
519+
[NewObject] DOMMatrix flipX();
520+
[NewObject] DOMMatrix flipY();
521+
[NewObject] DOMMatrix inverse();
522+
523+
[NewObject] DOMPoint transformPoint(optional DOMPointInit point);
524+
[NewObject] Float32Array toFloat32Array();
525+
[NewObject] Float64Array toFloat64Array();
526+
527+
stringifier;
528+
serializer = { attribute };
528529
};
529530

530531
[Constructor(optional (DOMString or sequence<unrestricted double>) init),

0 commit comments

Comments
 (0)