Skip to content

Commit 810c067

Browse files
committed
[css-grid] Add Disposition of Comments
1 parent c1ef3a6 commit 810c067

File tree

3 files changed

+290
-67
lines changed

3 files changed

+290
-67
lines changed

css-grid/Overview.bs

Lines changed: 7 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -4191,75 +4191,15 @@ Acknowledgements</h2>
41914191
Changes</h2>
41924192

41934193
<ul>
4194-
<li>
4195-
Internal table cell display types are <a>blockified</a>
4196-
instead of wrapped in an anonymous table.
4197-
(Updated to match changes to <a href="http://www.w3.org/TR/css-flexbox-1/">Flexbox</a>.)
4198-
<li>
4199-
Add <a href="#item-margins"></a>
4200-
and undefined whether percentages are calculated
4201-
against the block or inline axis of grid item’s containing block.
4202-
<li>
4203-
Added <a href="#order-accessibility"></a>
4204-
<li>
4205-
Fixed incorrect “Animation” lines in the property definition tables.
4206-
<li>
4207-
Allow <<fixed-size>> to accept ''minmax()'' notation.
4208-
<li>
4209-
Disallow <<flex>> sizes as minimum of ''minmax()'' function.
4210-
(Plan to allow it later, once we figure out how to make it work
4211-
in a manner consistent with <a href="https://lists.w3.org/Archives/Public/www-style/2016Mar/0333.html">author expectations</a>)
4212-
<li>
4213-
Fix errors and add clarifications to <a href="#auto-repeat">auto-repeat</a> definition.
4214-
<li>
4215-
Simplify subgrids so that their placement can happen before sizing.
4216-
<li>
4217-
Make ''subgrid'' a 'display' value rather than a 'grid-template-*' value,
4218-
disallowing single-axis subgridding.
4219-
(Single-axis subgridding may be added in the future,
4220-
but with a different syntax.)
4221-
<li>
4222-
Remove ability to name lines within a subgrid
4223-
(though this may be added back in a future level).
4224-
<li>
4225-
Allow multiple track listings in 'grid-auto-rows' and 'grid-auto-columns'
4226-
to facilitate use of subgrids with auto-flow.
4227-
<li>
4228-
Fix handling of assumed names of <a>implicit grid lines</a>
4229-
to account for the “search direction”.
4230-
<li>
4231-
Add back error handling for when the start and end lines are identical.
4232-
<li>
4233-
Corrected errors in finding the size of the implicit grid
4234-
in the <a>auto-placement algorithm</a>.
4235-
<li>
4236-
Auto-place into the <a>implicit grid</a> rather than the <a>explicit grid</a>.
4237-
<li>
4238-
Don't follow ''align-self/auto'' values of 'align-self' or 'justify-self'
4239-
on absolutely-positioned children;
4240-
just default to ''align-self/start'' alignment.
4241-
(Properties set on the grid container
4242-
usually aren't meant to affect absolutely-positioned children.)
4243-
<li>
4244-
Clarify that negative gutters are invalid.
4245-
<li>
4246-
Specify that gutters are omitted at fragmentation breaks.
4247-
<li>
4248-
Define location of a <a>grid line</a> when ther eare no <a>grid tracks</a>.
4249-
<li>
4250-
Correct sizing of the grid under
4251-
a <a lt="min-content constraint">min-content</a> or <a>max-content constraint</a>.
4252-
<li>
4253-
Allow 'max-width'/'max-height' to affect track sizing in a sensible way.
4254-
<li>
4255-
Allow fragmentation breaks between grid columns.
4256-
<li>
4257-
Various editorial improvements.
4194+
<li>Disallowed ''repeat()'' syntax in 'grid-template' shorthand syntax (since this is somewhat incompatible with the ASCII-art design of the syntax, and was never intended to be allowed).
4195+
<li>Fixed handling of ''fit-content()'' in the track sizing algorithm.
4196+
<li>Made the handling of <a>collapsed tracks</a> more explicit.
4197+
<li>Fixed grammar error in definition of <<auto-track-list>>.
4198+
<li>Fixed some tangled up text about how subgrids receive line names from their parent grid.
4199+
<li>Miscellaneous minor clarifications.
42584200
</ul>
42594201

4260-
A <a href="https://drafts.csswg.org/css-grid/issues-wd-20150917">Disposition of Comments</a> is available.
4261-
4262-
See also <a href="https://www.w3.org/TR/2015/WD-css-grid-1-20150917/#changes">previous changes</a>.
4202+
See also <a href="https://www.w3.org/TR/2016/WD-css-grid-1-20160519/#changes">previous changes</a>.
42634203

42644204
Privacy and Security Considerations {#priv-sec}
42654205
===============================================

css-grid/issues-wd-20160519.bsi

Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
Draft: https://www.w3.org/TR/2016/WD-css-grid-1-20160519/
2+
Title: CSS Grid Layout Level 1
3+
4+
----
5+
Issue 1.
6+
Summary: <line-names> invalid before repeat()
7+
From: Manuel Rego Casasnovas
8+
Comment: https://lists.w3.org/Archives/Public/www-style/2016May/0189.html
9+
Response: https://lists.w3.org/Archives/Public/www-style/2016May/0192.html
10+
Changes: https://hg.csswg.org/drafts/rev/a99892b17d43
11+
Closed: Accepted
12+
Resolved: Bugfix
13+
----
14+
Issue 2.
15+
Summary: What does a percentage mean inside fit-content()?
16+
From: Sergio Villar Senin
17+
Comment: https://lists.w3.org/Archives/Public/www-style/2016May/0161.html
18+
Response: https://lists.w3.org/Archives/Public/www-style/2016May/0203.html
19+
Changes: https://hg.csswg.org/drafts/rev/0f620563bcd9
20+
Closed: Accepted
21+
Verified:
22+
Resolved: Editor's discretion
23+
----
24+
Issue 3.
25+
Summary: Validity of repeat() syntax inside 'grid-template' shorthand
26+
From: Manuel Rego Casasnovas
27+
Comment: https://lists.w3.org/Archives/Public/www-style/2016May/0191.html
28+
Response: https://lists.w3.org/Archives/Public/www-style/2016May/0193.html
29+
----
30+
Issue 4.
31+
Summary: Clarifications to grid baselines
32+
From: Mats Palmgren
33+
Comment: https://github.com/w3c/csswg-drafts/issues/134
34+
Changes: https://hg.csswg.org/drafts/rev/52f9142b96cd
35+
Closed: Accepted (to css-align)
36+
Resolved: Editorial
37+
----
38+
Issue 5.
39+
Summary: Fill out Percentage line in propdef table
40+
From: teoli2003
41+
Comment: https://github.com/w3c/csswg-drafts/issues/175
42+
Closed: Accepted
43+
Resolved: Editorial
44+
----
45+
Issue 6.
46+
Summary: Figure numbering is broken
47+
From: Samuel Snopko
48+
Comment: https://github.com/w3c/csswg-drafts/issues/177
49+
Closed: Accepted
50+
Resolved: Editorial
51+
----
52+
Issue 7.
53+
Summary: Editorial tweaks to baselines section
54+
From: Mats Palmgren
55+
Comment: https://github.com/w3c/csswg-drafts/issues/196
56+
Closed: Accepted
57+
Resolved: Editorial
58+
----
59+
Issue 8.
60+
Summary: Grid line name vs collapsed tracks
61+
From: Sergio Villar Senin
62+
Comment: https://github.com/w3c/csswg-drafts/issues/172
63+
Closed: Accepted
64+
Resolved: https://lists.w3.org/Archives/Public/www-style/2016Jun/0180.html
65+
----
66+
Issue 9.
67+
Summary: Clarify that gutters are included in intrinsic sizes
68+
From: Mats Palmgren
69+
Comment: https://github.com/w3c/csswg-drafts/issues/246
70+
Changes: https://hg.csswg.org/drafts/rev/2b23c96ec410
71+
Closed: Accepted
72+
Resolved: Editorial
73+
----
74+
Issue 10.
75+
Summary: Clarify "all other properties" in grid shorthand definition
76+
From: Daniel Holbert
77+
Comment: https://github.com/w3c/csswg-drafts/issues/249
78+
Changes: https://hg.csswg.org/drafts/rev/1e4fee2f3a10
79+
Closed: Accepted
80+
Resolved: Editorial
81+
----
82+
Issue 11.
83+
Summary: Editorial fixes from workshop feedback
84+
From: Jonathan Kingston
85+
Changes: https://hg.csswg.org/drafts/rev/6dec070aaa22
86+
Closed: Accepted
87+
Resolved: Editorial
88+
----
89+
Issue 12.
90+
Summary: Add example for fixed-size spanner + alignment space distribution
91+
From: Rachel Andrew
92+
Comment: https://github.com/w3c/csswg-drafts/issues/215
93+
Changes: https://hg.csswg.org/drafts/rev/cbc66afa94f8
94+
Closed: Accepted
95+
Resolved: Editorial
96+
----
97+
Issue 13.
98+
Summary: Clamping for fit-content() is incorrect
99+
From: Mats Palmgren
100+
Comment: https://github.com/w3c/csswg-drafts/issues/209
101+
Changes: https://hg.csswg.org/drafts/rev/0f620563bcd9
102+
Closed: Accepted
103+
Resolved: =WG= Discuss and accept?
104+
----
105+
Issue 14.
106+
Summary: Application of block-axis baselines
107+
From: Mats Palmgren
108+
Comment: https://github.com/w3c/csswg-drafts/issues/197
109+
Open
110+
----

css-grid/issues-wd-20160519.html

Lines changed: 173 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
1+
<!DOCTYPE html>
2+
<meta charset="utf-8">
3+
<title>CSS Grid Layout Level 1 Disposition of Comments for 2016-05-19 WD</title>
4+
<style type="text/css">
5+
pre { border: solid thin silver; padding: 0.2em; white-space: normal; }
6+
pre > span { display: block; white-space: pre; }
7+
:not(pre).a { background: lightgreen }
8+
:not(pre).d { background: lightblue }
9+
:not(pre).oi { background: yellow }
10+
:not(pre).r { background: orange }
11+
:not(pre).fo { background: red }
12+
.open { border: solid red; }
13+
:target { box-shadow: 0.25em 0.25em 0.25em; }
14+
</style>
15+
16+
<h1>CSS Grid Layout Level 1 Disposition of Comments for 2016-05-19 WD</h1>
17+
18+
<p>Dated Draft: <a href="https://www.w3.org/TR/2016/WD-css-grid-1-20160519/">https://www.w3.org/TR/2016/WD-css-grid-1-20160519/</a>
19+
20+
<p>Editor's Draft: <a href="http://drafts.csswg.org/css-grid-1/">http://drafts.csswg.org/css-grid-1/</a>
21+
22+
<p>The following color coding convention is used for comments:</p>
23+
24+
<ul>
25+
<li class="a">Accepted or Rejected and positive response
26+
<li class="r">Rejected and no response
27+
<li class="fo">Rejected and negative response
28+
<li class="d">Deferred
29+
<li class="oi">Out-of-Scope or Invalid and not verified
30+
</ul>
31+
32+
<p class=open>Open issues are marked like this</p>
33+
34+
<p>An issue can be closed as <code>Accepted</code>, <code>OutOfScope</code>,
35+
<code>Invalid</code>, <code>Rejected</code>, or <code>Retracted</code>.
36+
<code>Verified</code> indicates commentor's acceptance of the response.</p>
37+
<pre class=' a' id='issue-1'>
38+
<span>Issue 1. <a href='#issue-1'>#</a></span>
39+
<span>Summary: &lt;line-names> invalid before repeat()</span>
40+
<span>From: Manuel Rego Casasnovas</span>
41+
<span>Comment: <a href='https://lists.w3.org/Archives/Public/www-style/2016May/0189.html'>https://lists.w3.org/Archives/Public/www-style/2016May/0189.html</a></span>
42+
<span>Response: <a href='https://lists.w3.org/Archives/Public/www-style/2016May/0192.html'>https://lists.w3.org/Archives/Public/www-style/2016May/0192.html</a></span>
43+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/a99892b17d43'>https://hg.csswg.org/drafts/rev/a99892b17d43</a></span>
44+
<span class="a">Closed: Accepted</span>
45+
<span>Resolved: Bugfix</span></pre>
46+
<pre class=' a' id='issue-2'>
47+
<span>Issue 2. <a href='#issue-2'>#</a></span>
48+
<span>Summary: What does a percentage mean inside fit-content()?</span>
49+
<span>From: Sergio Villar Senin</span>
50+
<span>Comment: <a href='https://lists.w3.org/Archives/Public/www-style/2016May/0161.html'>https://lists.w3.org/Archives/Public/www-style/2016May/0161.html</a></span>
51+
<span>Response: <a href='https://lists.w3.org/Archives/Public/www-style/2016May/0203.html'>https://lists.w3.org/Archives/Public/www-style/2016May/0203.html</a></span>
52+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/0f620563bcd9'>https://hg.csswg.org/drafts/rev/0f620563bcd9</a></span>
53+
<span class="a">Closed: Accepted</span>
54+
<span>Verified:</span>
55+
<span>Resolved: Editor's discretion</span></pre>
56+
<pre class=' ' id='issue-3'>
57+
<span>Issue 3. <a href='#issue-3'>#</a></span>
58+
<span>Summary: Validity of repeat() syntax inside 'grid-template' shorthand</span>
59+
<span>From: Manuel Rego Casasnovas</span>
60+
<span>Comment: <a href='https://lists.w3.org/Archives/Public/www-style/2016May/0191.html'>https://lists.w3.org/Archives/Public/www-style/2016May/0191.html</a></span>
61+
<span>Response: <a href='https://lists.w3.org/Archives/Public/www-style/2016May/0193.html'>https://lists.w3.org/Archives/Public/www-style/2016May/0193.html</a></span></pre>
62+
<pre class=' a' id='issue-4'>
63+
<span>Issue 4. <a href='#issue-4'>#</a></span>
64+
<span>Summary: Clarifications to grid baselines</span>
65+
<span>From: Mats Palmgren</span>
66+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/134'>https://github.com/w3c/csswg-drafts/issues/134</a></span>
67+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/52f9142b96cd'>https://hg.csswg.org/drafts/rev/52f9142b96cd</a></span>
68+
<span class="a">Closed: Accepted (to css-align)</span>
69+
<span>Resolved: Editorial</span></pre>
70+
<pre class=' a' id='issue-5'>
71+
<span>Issue 5. <a href='#issue-5'>#</a></span>
72+
<span>Summary: Fill out Percentage line in propdef table</span>
73+
<span>From: teoli2003</span>
74+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/175'>https://github.com/w3c/csswg-drafts/issues/175</a></span>
75+
<span class="a">Closed: Accepted</span>
76+
<span>Resolved: Editorial</span></pre>
77+
<pre class=' a' id='issue-6'>
78+
<span>Issue 6. <a href='#issue-6'>#</a></span>
79+
<span>Summary: Figure numbering is broken</span>
80+
<span>From: Samuel Snopko</span>
81+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/177'>https://github.com/w3c/csswg-drafts/issues/177</a></span>
82+
<span class="a">Closed: Accepted</span>
83+
<span>Resolved: Editorial</span></pre>
84+
<pre class=' a' id='issue-7'>
85+
<span>Issue 7. <a href='#issue-7'>#</a></span>
86+
<span>Summary: Editorial tweaks to baselines section</span>
87+
<span>From: Mats Palmgren</span>
88+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/196'>https://github.com/w3c/csswg-drafts/issues/196</a></span>
89+
<span class="a">Closed: Accepted</span>
90+
<span>Resolved: Editorial</span></pre>
91+
<pre class=' a' id='issue-8'>
92+
<span>Issue 8. <a href='#issue-8'>#</a></span>
93+
<span>Summary: Grid line name vs collapsed tracks</span>
94+
<span>From: Sergio Villar Senin</span>
95+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/172'>https://github.com/w3c/csswg-drafts/issues/172</a></span>
96+
<span class="a">Closed: Accepted</span>
97+
<span>Resolved: <a href='https://lists.w3.org/Archives/Public/www-style/2016Jun/0180.html'>https://lists.w3.org/Archives/Public/www-style/2016Jun/0180.html</a></span></pre>
98+
<pre class=' a' id='issue-9'>
99+
<span>Issue 9. <a href='#issue-9'>#</a></span>
100+
<span>Summary: Clarify that gutters are included in intrinsic sizes</span>
101+
<span>From: Mats Palmgren</span>
102+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/246'>https://github.com/w3c/csswg-drafts/issues/246</a></span>
103+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/2b23c96ec410'>https://hg.csswg.org/drafts/rev/2b23c96ec410</a></span>
104+
<span class="a">Closed: Accepted</span>
105+
<span>Resolved: Editorial</span></pre>
106+
<pre class=' a' id='issue-10'>
107+
<span>Issue 10. <a href='#issue-10'>#</a></span>
108+
<span>Summary: Clarify "all other properties" in grid shorthand definition</span>
109+
<span>From: Daniel Holbert</span>
110+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/249'>https://github.com/w3c/csswg-drafts/issues/249</a></span>
111+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/1e4fee2f3a10'>https://hg.csswg.org/drafts/rev/1e4fee2f3a10</a></span>
112+
<span class="a">Closed: Accepted</span>
113+
<span>Resolved: Editorial</span></pre>
114+
<pre class=' a' id='issue-11'>
115+
<span>Issue 11. <a href='#issue-11'>#</a></span>
116+
<span>Summary: Editorial fixes from workshop feedback</span>
117+
<span>From: Jonathan Kingston</span>
118+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/6dec070aaa22'>https://hg.csswg.org/drafts/rev/6dec070aaa22</a></span>
119+
<span class="a">Closed: Accepted</span>
120+
<span>Resolved: Editorial</span></pre>
121+
<pre class=' a' id='issue-12'>
122+
<span>Issue 12. <a href='#issue-12'>#</a></span>
123+
<span>Summary: Add example for fixed-size spanner + alignment space distribution</span>
124+
<span>From: Rachel Andrew</span>
125+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/215'>https://github.com/w3c/csswg-drafts/issues/215</a></span>
126+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/cbc66afa94f8'>https://hg.csswg.org/drafts/rev/cbc66afa94f8</a></span>
127+
<span class="a">Closed: Accepted</span>
128+
<span>Resolved: Editorial</span></pre>
129+
<pre class=' a' id='issue-13'>
130+
<span>Issue 13. <a href='#issue-13'>#</a></span>
131+
<span>Summary: Clamping for fit-content() is incorrect</span>
132+
<span>From: Mats Palmgren</span>
133+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/209'>https://github.com/w3c/csswg-drafts/issues/209</a></span>
134+
<span>Changes: <a href='https://hg.csswg.org/drafts/rev/0f620563bcd9'>https://hg.csswg.org/drafts/rev/0f620563bcd9</a></span>
135+
<span class="a">Closed: Accepted</span>
136+
<span>Resolved: =WG= Discuss and accept?</span></pre>
137+
<pre class='open ' id='issue-14'>
138+
<span>Issue 14. <a href='#issue-14'>#</a></span>
139+
<span>Summary: Application of block-axis baselines</span>
140+
<span>From: Mats Palmgren</span>
141+
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/197'>https://github.com/w3c/csswg-drafts/issues/197</a></span>
142+
<span>Open</span></pre>
143+
<script>
144+
(function () {
145+
var sheet = document.styleSheets[0];
146+
function addCheckbox(className) {
147+
var element = document.querySelector('*.' + className);
148+
var span = document.createElement('span');
149+
span.innerHTML = element.innerHTML;
150+
element.innerHTML = null;
151+
var check = document.createElement('input');
152+
check.type = 'checkbox';
153+
if (className == 'open') {
154+
check.checked = false;
155+
sheet.insertRule('pre:not(.open)' + '{}', sheet.cssRules.length);
156+
check.onchange = function (e) {
157+
rule.style.display = this.checked ? 'none' : 'block';
158+
}
159+
}
160+
else {
161+
check.checked = true;
162+
sheet.insertRule('pre.' + className + '{}', sheet.cssRules.length);
163+
check.onchange = function (e) {
164+
rule.style.display = this.checked ? 'block' : 'none';
165+
}
166+
}
167+
var rule = sheet.cssRules[sheet.cssRules.length - 1];
168+
element.appendChild(check);
169+
element.appendChild(span);
170+
}
171+
['a', 'd', 'fo', 'oi', 'r', 'open'].forEach(addCheckbox);
172+
}());
173+
</script>

0 commit comments

Comments
 (0)