Skip to content

Commit 8a7a6c1

Browse files
committed
[css-grid] Remove busted old example. Upgrade hand-drawn picture to SVG.
1 parent ba5cbc5 commit 8a7a6c1

File tree

2 files changed

+79
-52
lines changed

2 files changed

+79
-52
lines changed

css-grid/Overview.bs

Lines changed: 2 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1871,56 +1871,6 @@ The Implicit Grid</h3>
18711871
(or if there is no <a>explicit grid</a>)
18721872
auto-placement will also cause the generation of <a>implicit grid tracks</a>.
18731873

1874-
<div class='example'>
1875-
Issue: This is a bad example and needs to be totally rewritten.
1876-
It doesn't actually use the grid-auto-* properties,
1877-
which is confusing;
1878-
the example rendering is confusing and doesn't quite match what it would actually do,
1879-
because the second column would just shrink to zero as well;
1880-
and now that auto tracks stretch by default,
1881-
it's <em>totally wrong</em>--
1882-
all the auto tracks will stretch to fill the space,
1883-
so columns 3 and 4 are definitely visible.
1884-
1885-
This example illustrates the sizing of <a>implicit grid tracks</a>.
1886-
Note that <a>grid item</a> B is positioned on <a>grid line</a> 5,
1887-
which automatically creates <strong>four</strong> <a>implicit grid columns</a>.
1888-
However, only two of them
1889-
(the first and the last)
1890-
are occupied by any <a>grid items</a>,
1891-
so the two empty <a>grid tracks</a>
1892-
collapse to zero width.
1893-
1894-
<figure class="figure">
1895-
<img alt="" src="images/implicit-columns-and-rows.svg">
1896-
1897-
<figcaption>
1898-
A Grid with an implicit row and four implicit columns, two of which are zero-sized.
1899-
The black grid lines are from the <a>explicit grid</a>,
1900-
the gray grid lines are from the <a>implicit grid</a>.
1901-
The numbers indicate the line indexes.
1902-
</figcaption>
1903-
</figure>
1904-
1905-
<pre>
1906-
&lt;style>
1907-
#grid {
1908-
display: grid;
1909-
grid-template-columns: 20px;
1910-
grid-template-rows: 20px }
1911-
#A { grid-column: 1; grid-row: 1; }
1912-
#B { grid-column: 5; grid-row: 1 / span 2; }
1913-
#C { grid-column: 1 / span 2; grid-row: 2; }
1914-
&lt;/style>
1915-
1916-
&lt;div id="grid">
1917-
&lt;div id="A">A&lt;/div>
1918-
&lt;div id="B">B&lt;/div>
1919-
&lt;div id="C">C&lt;/div>
1920-
&lt;/div>
1921-
</pre>
1922-
</div>
1923-
19241874
<!--
19251875
███ ██ ██ ████████ ███████ ████████ ████████ ███ ██████ ██ ██ ██████
19261876
██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██ ██
@@ -1960,7 +1910,7 @@ Implicit Track Sizing: the 'grid-auto-rows' and 'grid-auto-columns' properties</
19601910
receives the last specified size, and so on backwards.
19611911

19621912
<div class="example">
1963-
<pre>
1913+
<pre class="lang-html">
19641914
&lt;style>
19651915
#grid {
19661916
display: grid;
@@ -1984,7 +1934,7 @@ Implicit Track Sizing: the 'grid-auto-rows' and 'grid-auto-columns' properties</
19841934
</pre>
19851935

19861936
<figure>
1987-
<img src="images/auto-flow.jpg" alt="">
1937+
<img src="images/auto-flow.svg" alt="">
19881938
<figcaption>A 2&times;2 grid with one explicit 20px&times;20px grid cell
19891939
in the first row+column
19901940
and three additional cells resulting from the implicit 40px column and row

css-grid/images/auto-flow.svg

Lines changed: 77 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)