Skip to content

Commit ba5a512

Browse files
committed
red, green, blue and hue should be unsigned (in CSSColorValue); add an issue about newstyle properties taking lists, such as backgroundImage
1 parent bbe84cd commit ba5a512

2 files changed

Lines changed: 16 additions & 8 deletions

File tree

cssom/Overview.html

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1734,6 +1734,10 @@ <h5 id=the-cssstyledeclarationproperties><span class=secno>3.6.2.2.
17341734
href="#cssstyledeclarationproperties">CSSStyleDeclarationProperties</a></code>
17351735
Interface</h5>
17361736

1737+
<p class=issue>Need to work out how to deal with properties that take one
1738+
or more values. Such as the "newstyle" 'background-image' etc. Suggestions
1739+
welcome.
1740+
17371741
<p>Objects implementing the <code><a
17381742
href="#cssstyledeclaration">CSSStyleDeclaration</a></code> interface <em
17391743
class=ct>must</em> also implement the <code><a
@@ -1871,14 +1875,14 @@ <h4 id=the-csscolorvalue><span class=secno>3.7.2. </span>The <code><a
18711875

18721876
<pre
18731877
class=idl>interface <dfn id=csscolorvalue>CSSColorValue</dfn> : <a href="#cssbasevalue">CSSBaseValue</a> {
1874-
attribute short red;
1878+
attribute unsigned short red;
18751879
attribute float redPercent; // 100% = 255
1876-
attribute short green;
1880+
attribute unsigned short green;
18771881
attribute float greenPercent; // 100% = 255
1878-
attribute short blue;
1882+
attribute unsigned short blue;
18791883
attribute float bluePercent; // 100% = 255
18801884
attribute float alpha; // float in range 0.0..1.0
1881-
attribute short hue; // integer in range 0..360
1885+
attribute unsigned short hue; // integer in range 0..360
18821886
attribute float saturation; // percentage
18831887
attribute float lightness; // percentage
18841888
attribute unsigned long hex3;

cssom/Overview.src.html

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1373,6 +1373,10 @@ <h5>The <code>CSS2Properties</code> Interface</h5>
13731373

13741374
<h5>The <code>CSSStyleDeclarationProperties</code> Interface</h5>
13751375

1376+
<p class="issue">Need to work out how to deal with properties that take one
1377+
or more values. Such as the "newstyle" 'background-image' etc. Suggestions
1378+
welcome.</p>
1379+
13761380
<p>Objects implementing the <code>CSSStyleDeclaration</code> interface
13771381
<em class="ct">must</em> also implement the
13781382
<code>CSSStyleDeclarationProperties</code> interface.</p>
@@ -1502,14 +1506,14 @@ <h4>The <code>CSSBaseValue</code> Interface</h4>
15021506
<h4>The <code>CSSColorValue</code> Interface</h4>
15031507

15041508
<pre class="idl">interface <dfn>CSSColorValue</dfn> : <span>CSSBaseValue</span> {
1505-
attribute short red;
1509+
attribute unsigned short red;
15061510
attribute float redPercent; // 100% = 255
1507-
attribute short green;
1511+
attribute unsigned short green;
15081512
attribute float greenPercent; // 100% = 255
1509-
attribute short blue;
1513+
attribute unsigned short blue;
15101514
attribute float bluePercent; // 100% = 255
15111515
attribute float alpha; // float in range 0.0..1.0
1512-
attribute short hue; // integer in range 0..360
1516+
attribute unsigned short hue; // integer in range 0..360
15131517
attribute float saturation; // percentage
15141518
attribute float lightness; // percentage
15151519
attribute unsigned long hex3;

0 commit comments

Comments
 (0)