Skip to content

Commit c3c59bb

Browse files
committed
Address ogerchikov@ feedback
1 parent 41ef1b4 commit c3c59bb

File tree

1 file changed

+21
-12
lines changed

1 file changed

+21
-12
lines changed

scroll-animations-1/Overview.bs

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -268,8 +268,8 @@ Typically, the scroll bar provides this visual indication but
268268
applications may wish to hide the scroll bar for aesthetic or useability
269269
reasons.
270270

271-
Using the 'animation-timeline' property, this example could be written
272-
as follows:
271+
Using the updated 'animation' shorthand that includes 'animation-timeline',
272+
this example could be written as follows:
273273

274274
<pre class='lang-css'>
275275
@media (prefers-reduced-motion: no-preference) {
@@ -285,15 +285,12 @@ as follows:
285285
width: 0px;
286286
height: 30px;
287287
background: red;
288-
animation: progress 1s linear;
289-
animation-fill-mode: forwards;
290-
animation-timeline: progress-timeline;
288+
animation: 1s linear forwards progress progress-timeline;
291289
}
292-
293-
294290
}
295291
</pre>
296292

293+
297294
If we use this API for this case, the example code will be as follow:
298295

299296
<pre class='lang-javascript'>
@@ -625,11 +622,19 @@ In this case, each possible value of type <<keyframes-name>> from
625622
{{DocumentTimeline}}, more specifically the <a>default document
626623
timeline</a>.
627624

628-
Note: Notice that the behavior for the case when no timeline with given name was
629-
found is different for either property. This ensures backward compatibility
630-
since most existing animations which have 'animation-name' specified expect to
631-
use <a>default document timeline</a>.
625+
Note: Notice that the behavior for the case where no timeline with the given
626+
name is found is different for these two properties. This ensures backward
627+
compatibility because all existing time-based animations with 'animation-name'
628+
specified expect to use <a>default document timeline</a>.
629+
630+
### Changes to the 'animation' shorthand property ### {#animation-shorthand}
631+
632+
The 'animation' shorthand property syntax is updated to accept an additional
633+
optional <<timeline-name>>.
634+
635+
<dfn>&lt;single-animation></dfn> = <<time>> || <<easing-function>> || <<time>> || <<single-animation-iteration-count>> || <<single-animation-direction>> || <<single-animation-fill-mode>> || <<single-animation-play-state>> || [ none | <<keyframes-name>> ] || [ none | <<timeline-name>> ]
632636

637+
Issue: Update css-animations spec instead of monkey-patching it here.
633638

634639
## The '@timeline' at-rule ## {#timeline-at-rule}
635640

@@ -691,8 +696,12 @@ have the following effects:
691696
'scroll-source' descriptor determines the scroll timeline's {{source}}. If
692697
specified as an '<selector()>' the scroll timeline's {{source}} is the
693698
[=scroll container=] identified by the <<id-selector>>, otherwise if not
694-
specified or none then it is the animation target's nearest scrollable ancestor.
699+
specified or none then it is the the {{scrollingElement}} of the {{Document}}
700+
<a lt="document associated with a window">associated</a> with the {{Window}}
701+
that is the <a>current global object</a>.
695702

703+
Issue(4338): consider choosing animation target's nearest scrollable ancestor
704+
instead of document's scrolling Element
696705

697706
<pre class='descdef'>
698707
Name: scroll-orientation

0 commit comments

Comments
 (0)