Skip to content

Commit e61c67b

Browse files
committed
[css-transforms-2] Fix translation in matrix recomposition algorithm.
You need to apply translation in all the columns. I found this while haunting a transform recomposition bug in the new Gecko style engine, which implemented this spec to the letter. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1459403
1 parent cef834c commit e61c67b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

css-transforms-2/Overview.bs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,7 @@ for (i = 0; i < 4; i++)
10441044
matrix[i][3] = perspective[i]
10451045

10461046
// apply translation
1047-
for (i = 0; i < 3; i++)
1047+
for (i = 0; i < 4; i++)
10481048
for (j = 0; j < 3; j++)
10491049
matrix[3][i] += translation[j] * matrix[j][i]
10501050

0 commit comments

Comments
 (0)