Skip to content

Commit f6c15d8

Browse files
committed
Change the issues text to not use the 1st person, as insisted on the list.
1 parent c97d972 commit f6c15d8

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

css-variables/Overview.html

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -292,12 +292,13 @@ <h2 id=defining-variables><span class=secno>2. </span> Defining Variables
292292
to them beyond the bare minimum that comes from them being valid
293293
properties.
294294

295-
<p class=issue>I'm using data-foo for their rough parallel (in terms of
296-
being completely user-extensible) with the data-* attributes in HTML.
297-
Might another name be better? Suggestions so far are "var-foo", "$foo",
298-
and "var(foo)" (the latter two are intended to directly resemble the usage
299-
of the variable). Obviously, usage of the variable should match, as
300-
"var(foo)" or "$foo" or whatever.
295+
<p class=issue>The naming here is loosely based on the form of custom data
296+
attributes in HTML5. However, as defined here, the syntax for variable
297+
usage is different from the syntax for variable definition (i.e. data-foo
298+
for definition, data(foo) for usage). Some have suggested that the
299+
syntaxes should should match, using functional syntax in both cases.
300+
Others have suggested using a prefixed symbol instead of functional syntax
301+
(e.g. $foo) for both the property and usage.
301302

302303
<p>The valid possible values of a data property are almost completely
303304
unrestricted. A data property can contain anything that is valid according
@@ -637,9 +638,9 @@ <h3 id=cssom-cssvariable><span class=secno>4.1. </span> Interface
637638
<h3 id=cssstyledeclaration-interface><span class=secno>4.2. </span>
638639
Additions to the <code>CSSStyleDeclaration</code> Interface</h3>
639640

640-
<p class=issue>The set of data properties is open-ended, so I'm not sure
641-
how best to represent this. I'd like to both expose the current set of
642-
properties with a non-initial value and allow setting of arbitrary
641+
<p class=issue>The set of data properties is open-ended, so it's not clear
642+
how best to represent this. Ideally, the CSSOM would expose the current
643+
set of properties with a non-initial value and allow setting of arbitrary
643644
properties. The most natural way seems to be to first, set up a getter
644645
behavior on the interface somehow that deals with data properties, and
645646
second, set up a <code>data</code> map that exposes the data properties

css-variables/Overview.src.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ <h2 id="defining-variables">
119119

120120
<p><em>Any</em> property name starting with the prefix "data-" is a <i>data property</i>. Data properties are defined to be valid but meaningless as they are meant solely for allowing authors to pass custom data around their page, similar to the <a href="http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#embedding-custom-non-visible-data-with-the-data-*-attributes">custom data attributes</a> in HTML. Other specifications and user agents must not assign a particular meaning to data properties or attach a specific effect to them beyond the bare minimum that comes from them being valid properties.</p>
121121

122-
<p class='issue'>I'm using data-foo for their rough parallel (in terms of being completely user-extensible) with the data-* attributes in HTML. Might another name be better? Suggestions so far are "var-foo", "$foo", and "var(foo)" (the latter two are intended to directly resemble the usage of the variable). Obviously, usage of the variable should match, as "var(foo)" or "$foo" or whatever.</p>
122+
<p class='issue'>The naming here is loosely based on the form of custom data attributes in HTML5. However, as defined here, the syntax for variable usage is different from the syntax for variable definition (i.e. data-foo for definition, data(foo) for usage). Some have suggested that the syntaxes should should match, using functional syntax in both cases. Others have suggested using a prefixed symbol instead of functional syntax (e.g. $foo) for both the property and usage.</p>
123123

124124
<p>The valid possible values of a data property are almost completely unrestricted. A data property can contain anything that is valid according to the <code>value</code> production in the <a href="http://www.w3.org/TR/CSS2/syndata.html#tokenization">CSS Core Grammar</a>. The values do not have to correspond to any existing CSS values, as they are not evaluated except to replace variables occuring within them until they are actually referenced in a normal property with a variable.</p>
125125

@@ -311,7 +311,7 @@ <h3 id='cssom-cssvariable'>
311311
<h3 id='cssstyledeclaration-interface'>
312312
Additions to the <code>CSSStyleDeclaration</code> Interface</h3>
313313

314-
<p class='issue'>The set of data properties is open-ended, so I'm not sure how best to represent this. I'd like to both expose the current set of properties with a non-initial value and allow setting of arbitrary properties. The most natural way seems to be to first, set up a getter behavior on the interface somehow that deals with data properties, and second, set up a <code>data</code> map that exposes the data properties that aren't set to their initial value.</p>
314+
<p class='issue'>The set of data properties is open-ended, so it's not clear how best to represent this. Ideally, the CSSOM would expose the current set of properties with a non-initial value and allow setting of arbitrary properties. The most natural way seems to be to first, set up a getter behavior on the interface somehow that deals with data properties, and second, set up a <code>data</code> map that exposes the data properties that aren't set to their initial value.</p>
315315

316316
<h2 id="conformance">
317317
Conformance</h2>

0 commit comments

Comments
 (0)