-
Notifications
You must be signed in to change notification settings - Fork 718
[css-view-transitions-2] How are invalid types validated? #10706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @tuankiet65 |
Aside from the DOM APIs, should the use of invalid names in the (I personally think it should, for clarity) |
See this resolution We specifically allowed invalid types in the I think this validation should be in I think it's important that it would make the whole at rule invalid, otherwise an at rule with invalid types would trigger a transition as if it has no types. |
I can't attend the APAC meeting, but proposing to leave the wording as is, as per previous resolution. |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> vmpstr: in VT we have a notion of "types" you can specify<TabAtkins> vmpstr: there are some type names that are invalid, like "none" or anything with "-ua-*" <TabAtkins> vmpstr: Tim asked how these are validated in the JS APi, and suggested throwing a syntax error <TabAtkins> vmpstr: previously we resolved not to do validation in the script api <TabAtkins> vmpstr: we just use what the author specified, but ignore the invalid bits <TabAtkins> vmpstr: a silent filtering <TabAtkins> vmpstr: we'd like to maintain that <TabAtkins> vmpstr: also, the @view-transition supports types, and Noam's comment is that if there are invalid types, the pref is for the whole block to be invalid, otherwise it can cause unexpected transitions to happen <fantasai> sounds reasonable to me <TabAtkins> vmpstr: So I think we'd like close-no-change, tho it's not entirely clear to me that @view-transition reflects fully what I said above. But the script API side, at least, reflects what I said <TabAtkins> astearns: In my reading of Tim's post, it sounds like he's fine as long as it's defined. <TabAtkins> vmpstr: I have the same reading <TabAtkins> fantasai: I checked with Tim and he's ok with resolving <TabAtkins> astearns: so proposed resolution is close no change, it's already handled <TabAtkins> RESOLVED: close no change |
Apparently there are invalid types (see #9534):
I would suggest throwing a TypeError or a SyntaxError when these are used in DOM APIs (notably the setters).
cc @noamr @khushalsagar @vmpstr @bokand
The text was updated successfully, but these errors were encountered: