Skip to content

[css-align] positional alignment values depend on alignment subject and container (rectangles) having direction and writing-mode #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbaron opened this issue May 19, 2017 · 1 comment

Comments

@dbaron
Copy link
Member

dbaron commented May 19, 2017

Many of the positional alignment keywords depend on a start-edge or end-edge of either the alignment container or the alignment subject. This, in turn, require knowing a direction and writing mode. However, the terminology section above defines the alignment container and the alignment subject as rectangles, which don't have these things.

It seems to me that the alignment container and alignment subject need to be defined as a rectangle associated with a box (or other source of direction and writing mode), and the definitions should be clear about which is the associated box (or direction/writing-mode). (I think the definitions are probably mostly obvious, but I could imagine somebody misinterpreting, e.g., for things like flex lines, grid tracks, or column boxes.)

(There's also mixing of the terms "start edge" and "start side", which should probably be used more consistently... unless there's a distinction that I'm missing. They're not links, so it's hard to know!)

@dbaron dbaron added the css-align-3 Current Work label May 20, 2017
@tabatkins
Copy link
Member

Okay, we've defined that the alignment subject/container have writing modes, and defined how they obtain them in all circumstances. Commits are 7a3b356, f44c052, and 01ab574.

Our usage of "edge" vs "side" is fairly regular - we use "side" when we're referring to a direction, and "edge" when we're referring to the actual edge of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants