Skip to content

[css-inline] Did root inline boxes become useless? #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Loirooriol opened this issue Jun 22, 2017 · 5 comments
Closed

[css-inline] Did root inline boxes become useless? #1551

Loirooriol opened this issue Jun 22, 2017 · 5 comments
Labels
Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-inline-3 Current Work

Comments

@Loirooriol
Copy link
Contributor

I think the root inline box was only useful to explain the styling of text directly contained in a block container. But in #1118 (comment) the WG resolved that text runs have their own styles, they no longer need a box.

So I think that, as currently defined, root inline boxes became useless, and can be removed. Is that so?

If I'm right don't remove them yet, I have some alternative ideas for them.

@dbaron
Copy link
Member

dbaron commented Jun 22, 2017

I think that the root inline box has a computed line-height property still helps explain how calculating the height of lines works, and possibly also vertical alignment.

@dbaron
Copy link
Member

dbaron commented Jun 22, 2017

(... which is actually why the concept was added in the first place)

@Loirooriol
Copy link
Contributor Author

Loirooriol commented Jun 22, 2017

I think that the root inline box has a computed line-height property still helps explain how calculating the height of lines works

Do you meant the strut? So now line-height applies only to inline boxes, but the root inline box inherits it from the block container, effectively replacing the following CSS2.1 quote?

On a block container element whose content is composed of inline-level elements, 'line-height' specifies the minimal height of line boxes within the element.

If so, this should be explained somewhere.

@tabatkins tabatkins added css-display-3 Current Work css-inline-3 Current Work labels Jul 12, 2017
@fantasai fantasai removed the css-display-3 Current Work label Jul 12, 2017
@fantasai fantasai changed the title [css-inline][css-display] Did root inline boxes become useless? [css-inline] Did root inline boxes become useless? Jul 12, 2017
@fantasai
Copy link
Collaborator

@Loirooriol The relevant portions of https://drafts.csswg.org/css-inline-3/ are now filled out. Please have a look and let me know if you're OK to close this issue. :)

@Loirooriol
Copy link
Contributor Author

Looks fine. But note that replacing the strut of the block container with the root inline box makes it less clear what should happen if there is ::first-line {line-height: 0}, because of #1384. See this non-interoperable testcase: https://bug1427241.bmoattachments.org/attachment.cgi?id=8939352

@Loirooriol Loirooriol added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Commenter Response Pending labels Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-inline-3 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants