Skip to content

[css-ui] Fix all current bikeshed warnings #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2015

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Apr 9, 2015

No description provided.

@tantek
Copy link
Member

tantek commented Apr 9, 2015

Looks good except for the changes:

from: <a spec="css-style-attr">style attribute</a>

to: <a href="http://dev.w3.org/csswg/css-style-attr/#style-attribute">style attribute</a>

What is the reason NOT to use spec="css-style-attr"?
And we should not be directly linking to dev.w3.org draft URLs as references (will block us from advancing to CR).

@plinss
Copy link
Member

plinss commented Apr 9, 2015

Rather than using absolute URLs to avoid Bikeshed warnings, you can update the linking defaults to select the proper specs:
https://github.com/tabatkins/bikeshed/blob/master/docs/definitions-autolinks.md#configuring-linking-defaults

Then Bikeshed should choose the /TR versions of the specs when generating for /TR.

@frivoal
Copy link
Collaborator Author

frivoal commented Apr 9, 2015

The problem with style attribute is that the the css-style-attr spec defines the term multiple times, so if we let bikeshed auto-link, even if we point it to the right spec, it will complain that it's ambiguous. The bug is in css-style-attr, not in css-ui, but I wanted to work around it to get to 0 warnings.

Since it is a REC already (and therefore is unlikely to change any time soon), I'll just link to TR instead.

@frivoal
Copy link
Collaborator Author

frivoal commented Apr 9, 2015

Link updated.

@tabatkins
Copy link
Member

If it defines the term multiple times, it's definitely a bug, but also it's probably okay for any of them to be the link target. To just shut Bikeshed up about the error, put it in an "Ignored Terms" metadata; that way it'll silently choose the first dfn in its database without emitting a warning.

@frivoal
Copy link
Collaborator Author

frivoal commented Apr 9, 2015

I thought "Ignored Terms" meant it wouldn't link at all. At least that's what the here doc claims:
https://github.com/tabatkins/bikeshed/blob/master/docs/metadata.md

@tabatkins
Copy link
Member

Whoops, ignore that documentation while I correct it. All Ignored Terms does is silence the warnings/errors from autolinking that term.

@tantek
Copy link
Member

tantek commented Apr 10, 2015

Hard-linking to the w3.org/TR drafts is a reasonable path forward for those references.

tantek added a commit that referenced this pull request Apr 10, 2015
[css-ui] Fix all current bikeshed warnings
@tantek tantek merged commit 9ceafa7 into w3c:master Apr 10, 2015
majido added a commit to majido/csswg-drafts that referenced this pull request Jul 31, 2018
Computed value as specified for longhands
frivoal added a commit to frivoal/csswg-drafts that referenced this pull request Nov 15, 2018
At the same time, I have renamed it to the better naming discussed in w3c#17
@frivoal frivoal deleted the florian/css-ui-warnings branch June 5, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants