-
Notifications
You must be signed in to change notification settings - Fork 707
[css-ui] Fix all current bikeshed warnings #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good except for the changes: from: to: What is the reason NOT to use spec="css-style-attr"? |
Rather than using absolute URLs to avoid Bikeshed warnings, you can update the linking defaults to select the proper specs: Then Bikeshed should choose the /TR versions of the specs when generating for /TR. |
The problem with style attribute is that the the css-style-attr spec defines the term multiple times, so if we let bikeshed auto-link, even if we point it to the right spec, it will complain that it's ambiguous. The bug is in css-style-attr, not in css-ui, but I wanted to work around it to get to 0 warnings. Since it is a REC already (and therefore is unlikely to change any time soon), I'll just link to TR instead. |
Link updated. |
If it defines the term multiple times, it's definitely a bug, but also it's probably okay for any of them to be the link target. To just shut Bikeshed up about the error, put it in an "Ignored Terms" metadata; that way it'll silently choose the first dfn in its database without emitting a warning. |
I thought "Ignored Terms" meant it wouldn't link at all. At least that's what the here doc claims: |
Whoops, ignore that documentation while I correct it. All |
Hard-linking to the w3.org/TR drafts is a reasonable path forward for those references. |
[css-ui] Fix all current bikeshed warnings
Computed value as specified for longhands
At the same time, I have renamed it to the better naming discussed in w3c#17
No description provided.