Skip to content

[css-flexbox] Flexbox spec uses inconsistent terminology: "Implied Minimum Size" vs "Automatic Minimum Size" #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dholbert opened this issue Sep 5, 2017 · 3 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work css-grid-1 Tracked in DoC

Comments

@dholbert
Copy link
Member

dholbert commented Sep 5, 2017

Flexbox Section 4.5 is titled "Implied Minimum Size of Flex Items" -- however, this term used in the title ("Implied Minimum Size") is never defined and has zero usages in the spec's prose, outside of that title (and footnotes about change history).

Instead, the spec's prose uses a different term, "Automatic Minimum Size", which was introduced in this commit and which seems to refer to the exact same concept. Here's a quote, showing the discrepancy:

4.5. Implied Minimum Size of Flex Items
[...]
In general, the automatic minimum size of a flex item is ...
https://drafts.csswg.org/css-flexbox-1/#min-size-auto

For consistency (and to avoid suggesting that there's an additional vaguely-defined concept in play), the title of this section should probably use the same term that we use in the prose -- i.e. the title needs s/Implied/Automatic/.

The exact same is true of Grid, too, BTW (section 6.6 over there).

6.6. Implied Minimum Size of Grid Items
[...]
The automatic minimum size for a grid item in a given dimension is ...
https://drafts.csswg.org/css-grid-1/#min-size-auto

CC @fantasai @tabatkins

@tabatkins
Copy link
Member

Sounds reasonable to me.

@fantasai
Copy link
Collaborator

fantasai commented Sep 6, 2017

Fixed. The reason, btw, that we used “Implied Minimum Size” rather than “Automatic Minimum Size” is because the automatic minimum size is particular calculation, which may or may not be used as the minimum depending on the value of min-width/min-height. What this section does is more than define the automatic minimum: it defines a new keyword for these properties that triggers that automatic minimum and makes it the initial value.

@dholbert
Copy link
Member Author

dholbert commented Sep 6, 2017

Thanks! (And thanks for the historical clarification RE "implied" -- makes sense.)

@fantasai fantasai added Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Sep 6, 2017
@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work css-grid-1 Tracked in DoC
Projects
None yet
Development

No branches or pull requests

3 participants