Skip to content

[css-animations] Add a way to fill in a keyframe other than the 0% or 100% keyframe using the underlying style #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
birtles opened this issue Oct 2, 2017 · 7 comments

Comments

@birtles
Copy link
Contributor

birtles commented Oct 2, 2017

Currently if you don't have a 0% or 100% keyframe, a keyframe is synthesized using the un-animated / underlying animated style (see #1841). It's odd, however, that this behavior only ever applies at the endpoints and you can never, for example, have a 50% keyframe where the property value is taken from the underlying style.

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Oct 2, 2017

Could we overload the revert keyword just a little bit more, to give it special behavior in keyframes? It already has different behavior depending on the origin of the rule it's in, and animations are treated as a separate origin for the cascade.

@birtles
Copy link
Contributor Author

birtles commented Oct 2, 2017

I think revert might make sense for the un-animated style, but in #1841 I'm proposing that we use the underlying animation's style in which case I don't think revert makes sense (since we'd be applying other styles from the same origin).

@fantasai
Copy link
Collaborator

fantasai commented Jun 2, 2023

What about revert-layer? Essentially overloading each animation’s style rules as being a distinct “cascade layer”...

CC @mirisuzanne

@fantasai fantasai added the Agenda+ Later Lower-priority items that are flagged for CSSWG discussion label Jun 2, 2023
@mirisuzanne
Copy link
Contributor

revert-layer makes sense to me for this, at least on first glance.

@Loirooriol
Copy link
Contributor

Loirooriol commented Nov 4, 2023

Already in the spec and ratified in #7083 (comment). Anything else to do?

@mirisuzanne
Copy link
Contributor

I don't think there's anything more to do here, no.

@mirisuzanne mirisuzanne added Closed Accepted by CSSWG Resolution Commenter Response Pending and removed Agenda+ Later Lower-priority items that are flagged for CSSWG discussion labels Dec 11, 2023
@mirisuzanne
Copy link
Contributor

Sorry, should have marked this first as pending commenter response. @birtles feel free to reopen if you think we need additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No change
Status: Unslotted
Development

No branches or pull requests

5 participants