-
Notifications
You must be signed in to change notification settings - Fork 715
[css-multicol] Improve column-fill example 26 and example 27 #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the notes however, in the ED the rules have been already corrected (you are referring to a now quite out of date WD, I'm going to request republication of the WD after doing the edits for the recent resolutions). In general you should look to the ED of any spec you want to comment on as that is our working document. I'l have a look at the other things when I next look at diagrams. |
At first, I did not understand what you meant. But now I do. You must have meant to say the column-rules.
I indeed looked at the Editor's Draft, section 7.1 column-fill before posting this. And there is no SVG images for example 26 and 27 in the Editor's Draft. The main purpose or motivation of this (issue) post is to see code examples that are as realistical and reliable and trustworthy as possible. |
The images in the ED currently aren't loading, there seems to be a server error. However as I mentioned they have been corrected already. |
server error should be fixed |
Peter, Rachel, There is also rather odd code in the examples. Eg |
That is code from the syntax highlighter, you don't need to view source to use the example. Unless you mean it is visible on the page, I can't see that. |
It seems like you're running into problems with the server's DoS filter blocking some requests (the large number of images in that spec push the limits). I've made some adjustments and it should be better. |
Rachel, (Now that I can see the newer SGV images) The font size definitely seems smaller now (by comparison with the font size of images in Latest published version) while the typeface is most likely the same as before. It's possible to approximate the code needed to generate such renderings. The SVG code of images was easier to understand before; now the SVG code is unfortunately a very long Peter, |
Hi @TalbotG - I'm trying to understand if you think there should be any changes from your comment. If yes, can you clarify? If not please let me know so I can close the issue - thanks! |
Rachel, To understand why, please load |
Also |
I think we may be thinking of two different things here, but the property I think Firefox Nightly has the correct behavior, and again doesn't need https://codepen.io/rachelandrew/pen/c1bb5629cf4a431054c188b9ca3d8190 I don't understand what you mean about two line boxes hence me wondering if we are talking about two different things. |
The default |
I'm afraid I still don't understand your statement about the example not being trustworthy. As I don't think we need to set orphans and widows to 1. Happy to change the example if I can understand a compelling reason why. |
coming from §7. Filling columns Column-fill: balance Example 26 with 2 line boxes Your codepen example uses In your codepen example, as soon as content height of multicolumn container is set to 42px (or greater) instead of 25px, then the effect of
Is this the case? Where does the spec state this? |
added fairly recently, the changelog details why the example is as it is. https://drafts.csswg.org/css-multicol/#changes-from-20180528 I think the example is correct in terms of the result it is demonstrating. You seem to be basing your suggestion on one browser implementation, and there are many examples in the spec that wouldn't work if we did that. |
Okay. I read the change... but I do not think this makes significant difference with regards to how I have replaced Example 26 without orphans: 1 and I still believe Chromium 73+ (and presumably Opera 12.16) handle the first 3 tests correctly, precisely and as expected. Right now, this statement
has no examples and no tests. |
please raise a new issue for each different thing - it is very hard to deal with more than one thing in an issue without things being missed. Thank you! |
Just wanted to add a note here to say this isn't being ignored. The CSSWG have resolved to revert the change which impacts these examples, pending discussion to resolve the issue. As this is going to change these examples, I'll take a look at them again once we have a resolution on the issues around |
The part of the spec this all referred to has been changed, and examples removed and renumbered. If you think there are still issues with examples in the updated spec please raise a new issue - thanks! |
@rachelandrew
After carefully examining the column-fill: balance Example 26 from the spec and the column-fill: auto Example 27 from the spec, I created these 2 pages:
column-fill: balance Example 26 GT
column-fill: auto Example-27 GT
I propose the following changes to examples 26 and 27 from the spec:
The text was updated successfully, but these errors were encountered: