Skip to content

Empty row-groups special treatment #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atotic opened this issue Dec 8, 2020 · 1 comment
Open

Empty row-groups special treatment #5772

atotic opened this issue Dec 8, 2020 · 1 comment
Labels
css-tables-3 Current Work

Comments

@atotic
Copy link
Contributor

atotic commented Dec 8, 2020

Empty row-groups are treated differently during layout. Spec does not mention this. The issues I've found are:

  1. When is row-group treated as empty?

Only row-groups with no children are treated as empty. Empty row child, or an abspos child, all trigger non-empty behavior.

  1. What is the size of an empty row-group?

external/wpt/css/css-tables/bounding-box-computation-3.html asserts that empty row-group should have width of 0

Chrome 87, FF 83, Safari 13 disagree, the row-group width matches other rows.
Pre-Chrome Edge has width of 0.

Suggestion: standardize empty row-group width to match table's grid, like other rows. This is prevalent implementation, and aligns with CSS behavior for empty blocks.

  1. border-spacing and empty row-groups?
    <table border-spacing:10px>
      <tbody></tbody>
      <tbody></tbody>
      <tbody><td>x</td></tbody>
    </table>

Chrome 87, Edge 17, Safari 13 do not generate border spacing for empty row groups. FF does.

What is the location of the first tbody? I believe its offsetTop should be 0 (no border spacing), but bounding-box-computation-3.html disagrees. It inserts border spacing before first row-group, even if it is empty. Unless all row-groups are empty, in which case there is no border-spacing.
Suggestion: empty row-groups should not generate any border spacing before or after ever.

@atotic atotic added the css-tables-3 Current Work label Dec 8, 2020
@atotic
Copy link
Contributor Author

atotic commented Dec 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-tables-3 Current Work
Projects
None yet
Development

No branches or pull requests

1 participant